Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
Subject: Re: async keepalive in http/2
From: Stefan Eissing <stefan.eissing@greenbytes.de>
In-Reply-To: 
 <CALK=YjNmZpv3rv7vZ0vhbwy-OzFEa5p_5hRcRMhzMX8zH_WS4w@mail.gmail.com>
Date: Fri, 22 Jan 2016 15:17:18 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <9C32A969-7CD1-4C13-B9F6-67AB06385C59@greenbytes.de>
References: <A2355D97-B984-472A-AC59-E5A483E55F35@greenbytes.de>
 <CALK=YjNmZpv3rv7vZ0vhbwy-OzFEa5p_5hRcRMhzMX8zH_WS4w@mail.gmail.com>
To: dev@httpd.apache.org


> Am 22.01.2016 um 15:16 schrieb Eric Covener <covener@gmail.com>:
>=20
> On Fri, Jan 22, 2016 at 9:12 AM, Stefan Eissing
> <stefan.eissing@greenbytes.de> wrote:
>> With the timeout behaviour of SSL reads fixed, I am making another =
attempt at have http/2 connections behave properly in async MPMs, e.g. =
event. One thing for that necessary as change in server is the hook to =
send a last GOAWAY frame before the connection is closed. Not sending it =
seems to confuse browsers, leading to unwanted failure of the subsequent =
request.
>>=20
>> You opinion therefore is required. On inspection of the connection =
shutdown handling, it seems that *all* MPM modules call, directly or =
indirectly, ap_start_lingering_close(). Keepalive connections are still =
healthy at this point and pool cleanup happens later, so this seems to =
be the place to install a new hook:
>>=20
>> AP_DECLARE_HOOK(int,pre_close_connection,(conn_rec *c)) as RUN_ALL
>>=20
>> Does this seem like the right place? Is the name any good?
>>=20
>> (forget the question about naming, should not have disturbed the =
beast...)
>=20
> Sounds reasonable, and c->pool cleanups you probably found are too
> late to write anything.

Indeed. All MPMs seem to cleanup pools way afterwards. Which is correct, =
I believe.=