httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Rumph <mike.ru...@oracle.com>
Subject Re: svn commit: r1723737 - in /httpd/test/mod_h2/trunk: mh2fuzz/h2c_conn.c mh2fuzz/h2c_session.c test/test_frames.sh
Date Fri, 08 Jan 2016 16:04:52 GMT
Comment below.

On 1/8/2016 7:26 AM, icing@apache.org wrote:
> Author: icing
> Date: Fri Jan  8 15:26:16 2016
> New Revision: 1723737
>
> URL: http://svn.apache.org/viewvc?rev=1723737&view=rev
> Log:
> normalized frame output for testing
>
> Modified:
>      httpd/test/mod_h2/trunk/mh2fuzz/h2c_conn.c
>      httpd/test/mod_h2/trunk/mh2fuzz/h2c_session.c
>      httpd/test/mod_h2/trunk/test/test_frames.sh
>
> Modified: httpd/test/mod_h2/trunk/mh2fuzz/h2c_conn.c
> URL: http://svn.apache.org/viewvc/httpd/test/mod_h2/trunk/mh2fuzz/h2c_conn.c?rev=1723737&r1=1723736&r2=1723737&view=diff
> ==============================================================================
> --- httpd/test/mod_h2/trunk/mh2fuzz/h2c_conn.c (original)
> +++ httpd/test/mod_h2/trunk/mh2fuzz/h2c_conn.c Fri Jan  8 15:26:16 2016
> @@ -419,12 +419,14 @@ apr_status_t h2c_conn_shutdown(h2c_conn
>               status = apr_socket_shutdown(c->socket, APR_SHUTDOWN_WRITE);
>           }
>           
> -        apr_socket_timeout_set(c->socket, apr_time_from_msec(250));
>           h2c_conn_want_io(c, H2C_CONN_READ);
>   
>           if (c->ssl) {
>               c->read = tls_shutdown_read;
>           }
> +
> +        status = c->read(c);
> +        status = h2c_conn_close(c);
It seems a bit odd to me to have the status field overlaid like this 
with consecutive calls.
Perhaps you are planning on adding status checking code, correct?
>       }
>       return status;
>   }
>
>


Mime
View raw message