Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
Subject: Re: Upgrade Summary
From: Stefan Eissing <stefan.eissing@greenbytes.de>
In-Reply-To: <5669FA25.3020100@gmail.com>
Date: Fri, 11 Dec 2015 09:56:08 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <90C59262-7253-4862-A430-F0510A3D854C@greenbytes.de>
References: 
 <CACsi250=dbRQKnsbE8JSdAZRm5x99gE0sgX3iQ-PHAx77euD1A@mail.gmail.com>
 <AB1691BE05AE7F4992697F2A0835627AC63BAB94@VOEXM10W.internal.vodafone.com>
 <F7B20D30-D34A-4805-A77D-F64F6428F6E3@greenbytes.de>
 <56660896.c74fc20a.15f56.0ebd@mx.google.com> <56660B43.2060507@gmail.com>
 <6B13DF2B-0586-42BB-B62F-59A7638B697D@greenbytes.de>
 <13FE9E7F-9620-4BF9-8EA4-57A6314D66BF@greenbytes.de>
 <9CCEFD7E-9ED3-4ED1-8F58-2134DD5310F9@gbiv.com>
 <CACsi252y7nX0kR9+JgSra7Q_5_LVqaR3z6ExPKg=Lhi8zhN4ew@mail.gmail.com>
 <566887B5.2080705@gmail.com>
 <CACsi253sTRbX2dnuq0yRP1sHb8vOos_9QaoYmA3TtYmnNx-Erg@mail.gmail.com>
 <5668CC4F.109@gmail.com>
 <CACsi253q+GanuRzOqBjaOe-h1w8uOcH6uFAcdres=+ig5q6+VA@mail.gmail.com>
 <5668EFDB.1050900@gmail.com>
 <CACsi252HOz3_BO6hJtRTfM=M6oB0ZUXpSvkPmKs8LWP3LCz8xA@mail.gmail.com>
 <5669FA25.3020100@gmail.com>
To: dev@httpd.apache.org

Jacob, thanks for the code! I will let this and my pseudo code stew over =
the weekend and then probably next week start the changes to upgrade =
handling.

//Stefan

> Am 10.12.2015 um 23:18 schrieb Jacob Champion <champion.p@gmail.com>:
>=20
> Okay, I finally have actual code to share. This is the original =
experimental pre_protocol_switch hook that Stefan and I were talking =
about a while ago [1], rebased onto 2.4.18. The two patches are =
available at
>=20
>    https://github.com/jchampio/httpd/commits/dev/websocket-protocols
>=20
> It is *not* an implementation of Stefan's most recent pseudocode (a =
primary difference is that his proposal does the filter + upgrade in one =
hook instead of two), and it doesn't solve many of the use cases that =
you've already agreed must be handled:
>=20
> - 100-continue is not handled correctly
> - the incoming request body is not correctly dealt with
> - there is only one switch point, at the handler stage
> - etc.
>=20
> *But* it is a working implementation from mod_websocket's point of =
view, so I offer it up primarily for informational purposes. The module =
making use of the new hook is available at
>=20
> =
https://github.com/jchampio/apache-websocket/blob/dev/hook/mod_websocket.c=

>=20
> You might be most interested in the =
mod_websocket_pre_protocol_switch() implementation (line 1627), which =
contains the pre-upgrade checks I need to do to remain compliant with =
RFC 6455.
>=20
> =3D=3D Asides =3D=3D
>=20
> 1) The current Protocols API does not correctly ignore upgrades from =
HTTP/1.0 requests; the latest commit to my experimental branch patched =
this.
>=20
> 2) As Stefan and I discussed in [1], Upgrade header values are =
case-sensitive (correct?), but the RFC 6455 declares that servers should =
respond to any protocol that's a case-insensitive match for "websocket". =
To make matters worse, the official IANA upgrade token is "WebSocket", =
but the RFC uses "websocket" throughout. I have seen both used in the =
wild (Autobahn uses WebSocket; Firefox uses websocket), and I'm not sure =
what the right way to resolve this is.
>=20
> Hope this helps. Again, I don't expect this to actually be part of the =
final solution, but sometimes it's nice to see code.
>=20
> --Jacob
>=20
> [1] =
https://mail-archives.apache.org/mod_mbox/httpd-dev/201509.mbox/%3C55FF85F=
0.8040106@gmail.com%3E