Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
Subject: Re: Upgrade Summary
From: Stefan Eissing <stefan.eissing@greenbytes.de>
In-Reply-To: <566984C7.5090908@oracle.com>
Date: Thu, 10 Dec 2015 15:06:13 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <00D7A5D3-4671-49DA-B710-03A54C8485BF@greenbytes.de>
References: 
 <CACsi250=dbRQKnsbE8JSdAZRm5x99gE0sgX3iQ-PHAx77euD1A@mail.gmail.com>
 <AB1691BE05AE7F4992697F2A0835627AC63BAB94@VOEXM10W.internal.vodafone.com>
 <F7B20D30-D34A-4805-A77D-F64F6428F6E3@greenbytes.de>
 <56660896.c74fc20a.15f56.0ebd@mx.google.com> <56660B43.2060507@gmail.com>
 <6B13DF2B-0586-42BB-B62F-59A7638B697D@greenbytes.de>
 <13FE9E7F-9620-4BF9-8EA4-57A6314D66BF@greenbytes.de>
 <9CCEFD7E-9ED3-4ED1-8F58-2134DD5310F9@gbiv.com>
 <CACsi252y7nX0kR9+JgSra7Q_5_LVqaR3z6ExPKg=Lhi8zhN4ew@mail.gmail.com>
 <566887B5.2080705@gmail.com>
 <CACsi253sTRbX2dnuq0yRP1sHb8vOos_9QaoYmA3TtYmnNx-Erg@mail.gmail.com>
 <5668CC4F.109@gmail.com>
 <CACsi253q+GanuRzOqBjaOe-h1w8uOcH6uFAcdres=+ig5q6+VA@mail.gmail.com>
 <5668EFDB.1050900@gmail.com>
 <CACsi252HOz3_BO6hJtRTfM=M6oB0ZUXpSvkPmKs8LWP3LCz8xA@mail.gmail.com>
 <EC8AA057-325B-4176-88A8-D9E5073C7F32@greenbytes.de>
 <566984C7.5090908@oracle.com>
To: dev@httpd.apache.org


> Am 10.12.2015 um 14:57 schrieb Mike Rumph <mike.rumph@oracle.com>:
>=20
> Question below:
>=20
> On 12/10/2015 2:46 AM, Stefan Eissing wrote:
>> 	int xxx_switch(conn_rec *c, request_rec *r, server_rec *s,
>> 		const char *protocol, int phase)
>> 	{
>> 		apr_status_t stats;
>>=20
>> 		if (strcmp(my_protocol, protocol)) {
> Do you mean "if my_protocol is protocol"?

If the protocol to switch to is not mine, DECLINE.

Should have written that in prose...

>> 			return DECLINED;
>> 		}
>> 	=09
>> 		if (need_handler && phase !=3D handler) {
>> 			return APR_EAGAIN;
>> 		}
>>=20
>> 		status =3D ap_upgrade_request(r, protocol, phase, =
my_additional_header, process_body);
>> 		if (status !=3D APR_SUCCESS) {
>> 			// any type of error, could also fail if NULL is =
passed instead of
>> 			// &process_body and request has body
>> 			return status;
>> 		}
>>=20
>> 		// c->output_filters can be written
>> 		// c->input_filters can be read, will pass data to =
process_body() until body is done,
>> 		// then return data up the filter chain.
>> 		process protocol;
>>=20
>> 		return APR_EOF;
>> 	}
>>=20
>>=20
>=20