httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: missing semicolon
Date Mon, 14 Dec 2015 17:03:10 GMT
On Mon, Dec 14, 2015 at 5:34 PM, Petr Gajdos <pgajdos@suse.cz> wrote:
> Hello Yann,
>
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/ssl_engine_io.c
>
> is missing semicolon in
>
> need_flush = !SSL_is_init_finished(outctx->filter_ctx->pssl)
>
> line. Relevant commit:
>
> http://svn.apache.org/viewvc?view=revision&revision=1707230

Thanks Petr for noticing, looks like no one is testing with OpenSSL <
0.9.8m here...

A simple (obvious) patch would be:

Index: modules/ssl/ssl_engine_io.c
===================================================================
--- modules/ssl/ssl_engine_io.c    (revision 1718739)
+++ modules/ssl/ssl_engine_io.c    (working copy)
@@ -217,7 +217,7 @@ static int bio_filter_out_write(BIO *bio, const ch
      * so limit the performance impact to handshake time.
      */
 #if OPENSSL_VERSION_NUMBER < 0x0009080df
-     need_flush = !SSL_is_init_finished(outctx->filter_ctx->pssl)
+     need_flush = !SSL_is_init_finished(outctx->filter_ctx->pssl);
 #else
      need_flush = SSL_in_connect_init(outctx->filter_ctx->pssl);
 #endif
--


>
> Thanks for 2.4.18.

Unfortunately this won't be fixed for 2.4.18 (being released already),
so I'll propose the patch for 2.4.19.

Regards,
Yann.

Mime
View raw message