httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1722369 - in /httpd/httpd/trunk: ./ docs/manual/mod/ modules/http2/
Date Wed, 30 Dec 2015 18:42:51 GMT
On Wed, Dec 30, 2015 at 5:12 PM,  <icing@apache.org> wrote:
> Author: icing
> Date: Wed Dec 30 16:12:35 2015
> New Revision: 1722369
>
> URL: http://svn.apache.org/viewvc?rev=1722369&view=rev
> Log:
> fixes after fuzzing tests, changed H2KeepAliveTimeout default
>
[]
>
> Modified: httpd/httpd/trunk/modules/http2/h2_workers.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_workers.c?rev=1722369&r1=1722368&r2=1722369&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/http2/h2_workers.c (original)
> +++ httpd/httpd/trunk/modules/http2/h2_workers.c Wed Dec 30 16:12:35 2015
> @@ -272,7 +272,7 @@ h2_workers *h2_workers_create(server_rec
>          apr_atomic_set32(&workers->max_idle_secs, 10);
>
>          apr_threadattr_create(&workers->thread_attr, workers->pool);
> -        apr_threadattr_detach_set(workers->thread_attr, 0);
> +        apr_threadattr_detach_set(workers->thread_attr, 1);

Hmm, aren't worker threads joined?
How does it work with eg. graceful restarts where (active) workers
need to be waited before the child exits?

Regards,
Yann.

Mime
View raw message