Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
MIME-Version: 1.0
In-Reply-To: <3F16527F-A2FE-4CEE-A87C-E98BB6DF07ED@sharp.fm>
References: <20151123200516.D444B3A043E@svn01-us-west.apache.org>
	<CCB57B20-8E08-4FA2-8A27-169C21A1D755@jaguNET.com>
	<3F16527F-A2FE-4CEE-A87C-E98BB6DF07ED@sharp.fm>
Date: Tue, 24 Nov 2015 17:15:36 +0100
Message-ID: 
 <CAKQ1sVMze747yq7KD70DL2DC8fDtZwKPr310urLD=ndr=kTb0w@mail.gmail.com>
Subject: Re: svn commit: r1715938 -
 /httpd/httpd/trunk/modules/cache/cache_util.c
From: Yann Ylavic <ylavic.dev@gmail.com>
To: httpd-dev <dev@httpd.apache.org>
Content-Type: text/plain; charset=UTF-8

On Tue, Nov 24, 2015 at 5:09 PM, Graham Leggett <minfrin@sharp.fm> wrote:
>
> A further optimisation - in many cases the fast path is really a case sensitive string comparison, given that the vast majority of the time the case being used is the case quoted in the spec.
>
> In other words, while mAx-AgE is valid, it is almost always max-age.
>
> Does it make sense to do a case sensitive comparison first, and then fall back to case insensitive?

Not sure:
    if (!strcmp(h, "max-age")
        || ap_cmpcasestr(h, "max-age"))
is likely to be a bit faster than a single ap_cmpcasestr() when it
matches, but much slower when it does not.

Regards,
Yann.