Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
MIME-Version: 1.0
In-Reply-To: <9F4E6A21-9544-4F43-834A-F8DCF20693C9@jaguNET.com>
References: 
 <CACsi253BCKpDOTmShACc3K1KCXeTBb1ugAgaioPXHvDCM+AGiw@mail.gmail.com>
	<9F4E6A21-9544-4F43-834A-F8DCF20693C9@jaguNET.com>
Date: Wed, 25 Nov 2015 13:31:38 -0600
Message-ID: 
 <CACsi251WHHQtc++VUjU+VmOPmkeJmYZzMFninyGktp36CmS-uw@mail.gmail.com>
Subject: Re: apr_token_* conclusions (was: Better casecmpstr[n]?)
From: William A Rowe Jr <wrowe@rowe-clan.net>
To: httpd <dev@httpd.apache.org>
Content-Type: multipart/alternative; boundary=001a1140ccc0cb82610525628107

--001a1140ccc0cb82610525628107
Content-Type: text/plain; charset=UTF-8

On Wed, Nov 25, 2015 at 1:12 PM, Jim Jagielski <jim@jagunet.com> wrote:

>
> > On Nov 25, 2015, at 12:42 PM, William A Rowe Jr <wrowe@rowe-clan.net>
> wrote:
> >
> > On Wed, Nov 25, 2015 at 10:17 AM, Jim Jagielski <jim@jagunet.com> wrote:
> > What is the current status? Is this on hold?
> >
> > It is looking for a good name.  I'm happy with apr_token_strcasecmp
> > to best indicate its use-case and provenance.  Does that work for
> > everyone?
>
> Still not super excited by the use of 'token' since it
> implies it should only be used for HTTP tokens and not
> in other cases where we use it to do ascii string comparisons
> (for example, when we check env-var settings or maybe directives)...
> yeah, they could also be lumped as 'tokens' I guess...
>
> ap_casecmpastr[n] for Case-insensitive CoMParison of Ascii STRing
>

APR has a naming pattern for various functional groups - this won't be the
last
one that is impacted by POSIX-ing what should already be posix :)

Because this is (a) str[n]casecmp I'm pretty strongly against name mangling
for the sake of name mangling, our consumers are C programmers, after all.
Well, most of them anyways... and they should be familiar enough names
for the Lua and PHP folks too.

And this isn't ASCII actually, we established that we want EBCDIC build of
APR + HTTPD to have the same thing.  Not ASCII, but POSIX locale.  We
will be careful about the description on that count.

Still -0.5 on introducing an ap_function, in light of the current mess in
httpd.h.
I'm only 10% of the way through reviewing @deprecated on that single header.

--001a1140ccc0cb82610525628107
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote">On W=
ed, Nov 25, 2015 at 1:12 PM, Jim Jagielski <span dir=3D"ltr">&lt;<a href=3D=
"mailto:jim@jagunet.com" target=3D"_blank">jim@jagunet.com</a>&gt;</span> w=
rote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-styl=
e:solid;padding-left:1ex"><span class=3D""><br>
&gt; On Nov 25, 2015, at 12:42 PM, William A Rowe Jr &lt;<a href=3D"mailto:=
wrowe@rowe-clan.net">wrowe@rowe-clan.net</a>&gt; wrote:<br>
&gt;<br>
&gt; On Wed, Nov 25, 2015 at 10:17 AM, Jim Jagielski &lt;<a href=3D"mailto:=
jim@jagunet.com">jim@jagunet.com</a>&gt; wrote:<br>
&gt; What is the current status? Is this on hold?<br>
&gt;<br>
&gt; It is looking for a good name.=C2=A0 I&#39;m happy with apr_token_strc=
asecmp<br>
&gt; to best indicate its use-case and provenance.=C2=A0 Does that work for=
<br>
&gt; everyone?<br>
<br>
</span>Still not super excited by the use of &#39;token&#39; since it<br>
implies it should only be used for HTTP tokens and not<br>
in other cases where we use it to do ascii string comparisons<br>
(for example, when we check env-var settings or maybe directives)...<br>
yeah, they could also be lumped as &#39;tokens&#39; I guess...<br>
<br>
ap_casecmpastr[n] for Case-insensitive CoMParison of Ascii STRing<br></bloc=
kquote><div><br></div><div>APR has a naming pattern for various functional =
groups - this won&#39;t be the last</div><div>one that is impacted by POSIX=
-ing what should already be posix :)</div><div><br></div><div><div>Because =
this is (a) str[n]casecmp I&#39;m pretty strongly against name mangling</di=
v><div>for the sake of name mangling, our consumers are C programmers, afte=
r all.</div><div>Well, most of them anyways... and they should be familiar =
enough names</div><div>for the Lua and PHP folks too.</div><div><br></div><=
/div><div>And this isn&#39;t ASCII actually, we established that we want EB=
CDIC build of</div><div>APR + HTTPD to have the same thing.=C2=A0 Not ASCII=
, but POSIX locale.=C2=A0 We</div><div>will be careful about the descriptio=
n on that count.</div><div><br></div><div>Still -0.5 on introducing an ap_f=
unction, in light of the current mess in httpd.h.<br></div><div>I&#39;m onl=
y 10% of the way through reviewing @deprecated on that single header.</div>=
<div><br></div><div><br></div></div></div></div>

--001a1140ccc0cb82610525628107--