Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: svn commit: r1715938 -
 /httpd/httpd/trunk/modules/cache/cache_util.c
From: Jim Jagielski <jim@jaguNET.com>
In-Reply-To: <BCD8A2D9-4A6D-4976-A1FC-6E6B51507875@sharp.fm>
Date: Tue, 24 Nov 2015 13:03:46 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <3DEF82C9-6DCF-42BF-8B51-AD08B08DAC27@jaguNET.com>
References: <20151123200516.D444B3A043E@svn01-us-west.apache.org>
 <CCB57B20-8E08-4FA2-8A27-169C21A1D755@jaguNET.com>
 <3F16527F-A2FE-4CEE-A87C-E98BB6DF07ED@sharp.fm>
 <CAKQ1sVMze747yq7KD70DL2DC8fDtZwKPr310urLD=ndr=kTb0w@mail.gmail.com>
 <BCD8A2D9-4A6D-4976-A1FC-6E6B51507875@sharp.fm>
To: dev@httpd.apache.org


> On Nov 24, 2015, at 11:18 AM, Graham Leggett <minfrin@sharp.fm> wrote:
>=20
> On 24 Nov 2015, at 6:15 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
>=20
>> Not sure:
>>   if (!strcmp(h, "max-age")
>>       || ap_cmpcasestr(h, "max-age"))
>> is likely to be a bit faster than a single ap_cmpcasestr() when it
>> matches, but much slower when it does not.
>=20
> Yep, that=E2=80=99s the point.
>=20
> The vast majority of comparisons are lowercase for tokens like this. =
Might as well test that fast path first before testing the worst case =
scenario.
>=20

Is there REALLY that much of a diff between

	if (ucharmap[*ps1] !=3D ucharmap[*ps2]) {

and

	if (*ps1 !=3D *ps2) {

to muddle up the code like that though??