Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: strncasecmp
From: Jim Jagielski <jim@jaguNET.com>
In-Reply-To: 
 <CAKQ1sVPtxJRfyeS5LBJ7FsYJW5=36p9qp6FuE3hPFi19+WR9Eg@mail.gmail.com>
Date: Fri, 20 Nov 2015 13:53:39 -0500
Content-Transfer-Encoding: 7bit
Message-Id: <301856DC-1727-4158-96B0-8233D2E01CA9@jaguNET.com>
References: <FD60B807-973B-4FFD-B32F-E7608A6CD374@jaguNET.com>
 <CAKQ1sVPtxJRfyeS5LBJ7FsYJW5=36p9qp6FuE3hPFi19+WR9Eg@mail.gmail.com>
To: dev@httpd.apache.org

Implemented in r1715401

If people want to nit-pick about naming and wish to
rename it to something else, be my guest.

> On Nov 20, 2015, at 1:03 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
> 
> +1
> 
> On Fri, Nov 20, 2015 at 6:17 PM, Jim Jagielski <jim@jagunet.com> wrote:
>> We use str[n]casecmp quite a bit. The rub is that some
>> platforms use a sensible implementation (such as OSX) which
>> uses a upper-lowercase map and is v. fast, and others
>> use a brain-dead version which does an actual tolower() of
>> each char in the string as it tests. We actually try to
>> handle this in many cases by doing a switch/case test on the
>> 1st char to fast path the strncasecmp, resulting in ugly code.
>> 
>> This is crazy.
>> 
>> I propose a ap_strncasecmp/ap_strcasecmp which we should use.
>> Ideally, it would be in apr but no need to wait for that
>> to happen :)
>> 
>> Unless people have heartburn about this, I will add next week.