httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christophe JAILLET <christophe.jail...@wanadoo.fr>
Subject cppcheck warning with mod_http2
Date Wed, 11 Nov 2015 08:21:09 GMT
Hi,

mod_http2 generates some new cppcheck warnings:

modules/http2/h2_config.h
62    unnecessaryForwardDeclaration    style    The struct 'h2_config' 
forward declaration is unnecessary. Type struct is already declared earlier.
modules/http2/h2_io_set.h
25    unnecessaryForwardDeclaration    style    The struct 'h2_io_set' 
forward declaration is unnecessary. Type struct is already declared earlier.
modules/http2/h2_mplx.c
106    redundantAssignment    style    Variable 'status' is reassigned a 
value before the old one has been used.
modules/http2/h2_request.c
87    unsignedLessThanZero    style    Checking if unsigned variable 
'nlen' is less than zero.
modules/http2/h2_response.h
34    unnecessaryForwardDeclaration    style    The struct 'h2_response' 
forward declaration is unnecessary. Type struct is already declared earlier.
modules/http2/h2_session.c
1150    unusedStructMember    style    struct or union member 
'nvctx_t::offset' is never used.
modules/http2/h2_task.c
211    redundantAssignment    style    Variable 'status' is reassigned a 
value before the old one has been used.
modules/http2/h2_to_h1.c
284    redundantAssignment    style    Variable 'status' is reassigned a 
value before the old one has been used.



At least this one is spurious:
    modules/http2/h2_session.c
    1150    unusedStructMember    style    struct or union member 
'nvctx_t::offset' is never used.

nvctx_t is defined both in h2_session and in h2_response.
Only the latter seems useful. I think that the one in h2_session could 
be completely dropped.


Best regards,
CJ


Mime
View raw message