httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Eissing <stefan.eiss...@greenbytes.de>
Subject Re: svn commit: r1711503 - in /httpd/httpd/trunk/modules/http2: h2_conn_io.c h2_conn_io.h h2_io.c h2_io.h h2_mplx.c h2_mplx.h h2_session.c h2_stream.c h2_stream.h h2_task_input.c h2_util.c h2_util.h
Date Mon, 02 Nov 2015 09:31:54 GMT

> Am 01.11.2015 um 08:22 schrieb Christophe JAILLET <christophe.jaillet@wanadoo.fr>:
> 
> Hi,
> 
> Le 30/10/2015 17:15, icing@apache.org a écrit :
>> [...]+            if (status == APR_SUCCESS && padlen) {
>> +                if (padlen) {
>> +                    char pad[256];
>> +                    memset(pad, 0, padlen);
> 
> You could save this 'pad' buffer and the 'memset' by also using the data from the 'static
char immortal_zeros[256];' introduced above.

Good idea, will do.

> Maybe, using NGHTTP2_MAX_PADLEN instead of the 256 hard coded value would be cleaner?

That is in an internal header file from nghttp2. Will add an own #define in mod_http2 headers
to make it clear where the limit comes from.

//Stefan
Mime
View raw message