httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1650655 - in /httpd/httpd/branches/2.4.x: CHANGES STATUS modules/proxy/proxy_util.c
Date Tue, 17 Nov 2015 13:20:51 GMT
On Tue, Nov 17, 2015 at 2:12 PM, Jim Jagielski <jim@jagunet.com> wrote:
> I would propose that if the below is NOT the cause, then the
> old version remain. There is a lot to be said for simplicity
> and clarity.

There is still a (per request) call to ap_proxy_port_of_scheme() in
ap_proxy_determine_connection() we can't avoid (AFAICT), so it is
worth optimize it anyway IMO.

>
> Plus, the whole reason for ap_proxy_port_of_scheme() was
> to avoid the sorts of special numbers the below "hides"
> in various locations.

Agreed, the optimization in ap_proxy_port_of_scheme() only is probably better.

Mime
View raw message