httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r1715876 - in /httpd/httpd/trunk: modules/cache/ modules/filters/ modules/generators/ modules/http/ modules/http2/ modules/loggers/ modules/mappers/ modules/metadata/ modules/proxy/ modules/slotmem/ modules/test/ server/
Date Mon, 23 Nov 2015 19:37:49 GMT


On 11/23/2015 05:46 PM, ylavic@apache.org wrote:
> Author: ylavic
> Date: Mon Nov 23 16:46:01 2015
> New Revision: 1715876
> 
> URL: http://svn.apache.org/viewvc?rev=1715876&view=rev
> Log:
> Use new ap_casecmpstr[n]() functions where appropriate (not exhaustive).
> 
> Modified:
>     httpd/httpd/trunk/modules/cache/cache_util.c
>     httpd/httpd/trunk/modules/filters/mod_deflate.c
>     httpd/httpd/trunk/modules/filters/mod_include.c
>     httpd/httpd/trunk/modules/filters/mod_proxy_html.c
>     httpd/httpd/trunk/modules/generators/mod_autoindex.c
>     httpd/httpd/trunk/modules/generators/mod_cgi.c
>     httpd/httpd/trunk/modules/generators/mod_cgid.c
>     httpd/httpd/trunk/modules/http/byterange_filter.c
>     httpd/httpd/trunk/modules/http/http_filters.c
>     httpd/httpd/trunk/modules/http2/h2_from_h1.c
>     httpd/httpd/trunk/modules/loggers/mod_log_config.c
>     httpd/httpd/trunk/modules/mappers/mod_rewrite.c
>     httpd/httpd/trunk/modules/metadata/mod_cern_meta.c
>     httpd/httpd/trunk/modules/metadata/mod_headers.c
>     httpd/httpd/trunk/modules/proxy/ajp_header.c
>     httpd/httpd/trunk/modules/proxy/mod_proxy.c
>     httpd/httpd/trunk/modules/proxy/mod_proxy_ajp.c
>     httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c
>     httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c
>     httpd/httpd/trunk/modules/proxy/mod_proxy_fdpass.c
>     httpd/httpd/trunk/modules/proxy/mod_proxy_ftp.c
>     httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
>     httpd/httpd/trunk/modules/proxy/mod_proxy_scgi.c
>     httpd/httpd/trunk/modules/proxy/mod_proxy_wstunnel.c
>     httpd/httpd/trunk/modules/proxy/mod_serf.c
>     httpd/httpd/trunk/modules/proxy/proxy_util.c
>     httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c
>     httpd/httpd/trunk/modules/test/mod_policy.c
>     httpd/httpd/trunk/server/mpm_unix.c
>     httpd/httpd/trunk/server/protocol.c
>     httpd/httpd/trunk/server/util.c
>     httpd/httpd/trunk/server/util_expr_eval.c
>     httpd/httpd/trunk/server/util_script.c
> 
> Modified: httpd/httpd/trunk/modules/cache/cache_util.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cache/cache_util.c?rev=1715876&r1=1715875&r2=1715876&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/cache/cache_util.c (original)
> +++ httpd/httpd/trunk/modules/cache/cache_util.c Mon Nov 23 16:46:01 2015

> @@ -1066,59 +1045,46 @@ int ap_cache_control(request_rec *r, cac
>                          cc->max_stale = 1;
>                          cc->max_stale_value = -1;
>                      }
> -                    break;
>                  }
> -                else if (!strncasecmp(token, "min-fresh", 9)) {
> +                else if (!ap_casecmpstrn(token, "min-fresh", 9)) {
>                      if (token[9] == '=') {
>                          cc->min_fresh = 1;
>                          cc->min_fresh_value = apr_atoi64(token + 10);
>                      }
> -                    break;
> -                }
> -                else if (!strcasecmp(token, "must-revalidate")) {
> -                    cc->must_revalidate = 1;
>                  }
>                  break;
>              }
>              case 'o':
>              case 'O': {
> -                if (!strcasecmp(token, "only-if-cached")) {
> +                if (!ap_casecmpstr(token, "only-if-cached")) {
>                      cc->only_if_cached = 1;
>                  }
>                  break;
>              }
> -            case 'p':
> -            case 'P': {
> -                /* handle most common quickest cases... */
> -                if (!strcmp(token, "private")) {
> -                    cc->private = 1;
> -                }
> -                /* ...then try slowest cases */
> -                else if (!strcasecmp(token, "public")) {
> +            case 'p': {

Why removing the uppercase 'P' case here?

Regards

RĂ¼diger

Mime
View raw message