httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r1715938 - /httpd/httpd/trunk/modules/cache/cache_util.c
Date Tue, 24 Nov 2015 15:38:13 GMT

> On Nov 24, 2015, at 10:28 AM, Eric Covener <covener@gmail.com> wrote:
> 
> On Tue, Nov 24, 2015 at 10:21 AM, Jim Jagielski <jim@jagunet.com> wrote:
>> For these types of paths, where we use a switch/case against
>> the 1st char of the token, the real reason why we used that
>> impl was to avoid the (expected) expensive string comparison.
> 
> Maybe naively, I thought we were saving some potential function
> call overhead here rather than some strcasecmp overhead.

Yeah... you are likely right. In which case, we should adjust
ala the suggested

	if (!ap_casecmpstr(token+1, "ublic")) {

implementation. Yeah, that's ugly, I agree.

Mime
View raw message