httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Eissing <stefan.eiss...@greenbytes.de>
Subject Re: svn commit: r1715294 - /httpd/httpd/trunk/server/core.c
Date Fri, 20 Nov 2015 09:11:02 GMT
+1 for lowercasing and pls backport, since it just arrived as is in 2.4.x, i think.

> Am 20.11.2015 um 00:24 schrieb William A Rowe Jr <wrowe@rowe-clan.net>:
> 
> It wouldn't hurt to change this though, the tokens are generally represented in lowercase,
and this could avoid case folding I suppose.
> 
> How often do we see value tokens as upper case from httpd?  Let's be consistent although
it isn't strictly required.
> 
> 
> 
> On Thu, Nov 19, 2015 at 3:54 PM, <jailletc36@apache.org> wrote:
> Author: jailletc36
> Date: Thu Nov 19 21:54:48 2015
> New Revision: 1715294
> 
> URL: http://svn.apache.org/viewvc?rev=1715294&view=rev
> Log:
> Revert r1715289 (Connection header field should use "upgrade" instead of "Upgrade")
> 
> This is case-insensitive, so no need for such a change.
> 
> Modified:
>     httpd/httpd/trunk/server/core.c
> 
> Modified: httpd/httpd/trunk/server/core.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/core.c?rev=1715294&r1=1715293&r2=1715294&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/server/core.c (original)
> +++ httpd/httpd/trunk/server/core.c Thu Nov 19 21:54:48 2015
> @@ -5379,7 +5379,7 @@ static int core_upgrade_handler(request_
>                      /* Let the client know what we are upgrading to. */
>                      apr_table_clear(r->headers_out);
>                      apr_table_setn(r->headers_out, "Upgrade", protocol);
> -                    apr_table_setn(r->headers_out, "Connection", "upgrade");
> +                    apr_table_setn(r->headers_out, "Connection", "Upgrade");
> 
>                      r->status = HTTP_SWITCHING_PROTOCOLS;
>                      r->status_line = ap_get_status_line(r->status);
> @@ -5404,7 +5404,7 @@ static int core_upgrade_handler(request_
>          if (upgrades && upgrades->nelts > 0) {
>              char *protocols = apr_array_pstrcat(r->pool, upgrades, ',');
>              apr_table_setn(r->headers_out, "Upgrade", protocols);
> -            apr_table_setn(r->headers_out, "Connection", "upgrade");
> +            apr_table_setn(r->headers_out, "Connection", "Upgrade");
>          }
>      }
> 
> 
> 
> 


Mime
View raw message