Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.0 \(3094\))
Subject: Re: stop the press!
From: Stefan Eissing <stefan.eissing@greenbytes.de>
In-Reply-To: <A7454680-1A43-46BA-9D31-43744AADCEF7@jaguNET.com>
Date: Thu, 8 Oct 2015 12:48:04 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <F70D14F9-CC07-4E16-BC61-91904CC46212@greenbytes.de>
References: <B3EE8F05-26C7-4B79-B335-B6A431571022@greenbytes.de>
 <A7454680-1A43-46BA-9D31-43744AADCEF7@jaguNET.com>
To: dev@httpd.apache.org

Ah, good and useful hint! Currently working on a better patch and =
backport that myself then. Thanks!

> Am 08.10.2015 um 12:46 schrieb Jim Jagielski <jim@jaguNET.com>:
>=20
> The mod_http2 stuff for 2.4.x is CTR, meaning that one does not
> need to propose a backport in STATUS for it to be included; rather,
> one simply patches 2.4 as required, while ensuring that one doesn't
> break anything :)
>=20
>> On Oct 8, 2015, at 6:06 AM, Stefan Eissing =
<stefan.eissing@greenbytes.de> wrote:
>>=20
>> I need a tiny patch for mod_http2 that solves an empty response =
problem with the latest nghttp2 libraries:
>>=20
>> Jim, can we get that still in? Commited in trunk as r1707468.
>>=20
>> //Stefan
>>=20
>> Index: modules/http2/h2_util.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- modules/http2/h2_util.c	(revision 1707467)
>> +++ modules/http2/h2_util.c	(revision 1707468)
>> @@ -484,20 +484,39 @@
>>=20
>> int h2_util_has_eos(apr_bucket_brigade *bb, apr_size_t len)
>> {
>> -    apr_bucket *b, *end;
>> +    apr_bucket *b;
>>=20
>> -    apr_status_t status =3D last_not_included(bb, len, 0, 0, &end);
>> -    if (status !=3D APR_SUCCESS) {
>> -        return status;
>> +    if (len =3D=3D 0) {
>> +        /* special case: this is only true, if there are only meta
>> +         * and an eos bucket in the brigade head.
>> +         */
>> +        for (b =3D APR_BRIGADE_FIRST(bb);
>> +             b !=3D APR_BRIGADE_SENTINEL(bb);
>> +             b =3D APR_BUCKET_NEXT(b))
>> +        {
>> +            if (!APR_BUCKET_IS_METADATA(b) && b->length !=3D 0) {
>> +                break;
>> +            }
>> +            else if (APR_BUCKET_IS_EOS(b)) {
>> +                return 1;
>> +            }
>> +        }
>>    }
>> -   =20
>> -    for (b =3D APR_BRIGADE_FIRST(bb);
>> -         b !=3D APR_BRIGADE_SENTINEL(bb) && b !=3D end;
>> -         b =3D APR_BUCKET_NEXT(b))
>> -    {
>> -        if (APR_BUCKET_IS_EOS(b)) {
>> -            return 1;
>> +    else {
>> +        apr_bucket *end;
>> +        apr_status_t status =3D last_not_included(bb, len, 0, 0, =
&end);
>> +        if (status !=3D APR_SUCCESS) {
>> +            return status;
>>        }
>> +       =20
>> +        for (b =3D APR_BRIGADE_FIRST(bb);
>> +             b !=3D APR_BRIGADE_SENTINEL(bb) && b !=3D end;
>> +             b =3D APR_BUCKET_NEXT(b))
>> +        {
>> +            if (APR_BUCKET_IS_EOS(b)) {
>> +                return 1;
>> +            }
>> +        }
>>    }
>>    return 0;
>> }
>> Index: modules/http2/h2_version.h
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- modules/http2/h2_version.h	(revision 1707467)
>> +++ modules/http2/h2_version.h	(revision 1707468)
>> @@ -20,7 +20,7 @@
>> * @macro
>> * Version number of the h2 module as c string
>> */
>> -#define MOD_HTTP2_VERSION "0.9.9"
>> +#define MOD_HTTP2_VERSION "1.0.0"
>>=20
>> /**
>> * @macro
>> @@ -28,7 +28,7 @@
>> * release. This is a 24 bit number with 8 bits for major number, 8 =
bits
>> * for minor and 8 bits for patch. Version 1.2.3 becomes 0x010203.
>> */
>> -#define MOD_HTTP2_VERSION_NUM 0x000909
>> +#define MOD_HTTP2_VERSION_NUM 0x010000
>>=20
>>=20
>> #endif /* mod_h2_h2_version_h */
>>=20
>=20