Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 711A4175E3 for ; Thu, 29 Oct 2015 09:09:37 +0000 (UTC) Received: (qmail 15355 invoked by uid 500); 29 Oct 2015 09:09:36 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 15276 invoked by uid 500); 29 Oct 2015 09:09:36 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 15265 invoked by uid 99); 29 Oct 2015 09:09:36 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Oct 2015 09:09:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E2115C040B for ; Thu, 29 Oct 2015 09:09:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.111 X-Spam-Level: X-Spam-Status: No, score=-0.111 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=greenbytes.de Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ngvOi8T09jOR for ; Thu, 29 Oct 2015 09:09:34 +0000 (UTC) Received: from mail.greenbytes.de (mail.greenbytes.de [217.91.35.233]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id 92D3B2115A for ; Thu, 29 Oct 2015 09:09:34 +0000 (UTC) Received: from [192.168.1.150] (unknown [217.91.35.233]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mail.greenbytes.de (Postfix) with ESMTPSA id 7792615A03B9 for ; Thu, 29 Oct 2015 10:09:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=greenbytes.de; s=mail; t=1446109765; bh=8p/V901c3fMcs3BuVjaPTD60qFzgE1Ut3LMtMIogQCc=; h=Subject:From:In-Reply-To:Date:References:To:From; b=opb7kM+UIafwHBbFqYU2+Eti+/Us97mmAxFJNszjRJP6QKylTDZPj1KXFKuuDAPL8 VkHWkrqQGdruQbKtapEqkCK+0GunWReD++iO9e4xw0lBb3B3NmMIsQUEAtoh2WweFC dm9KXfij743oC9peHnzFi3UU9+Ulrm3C5xxpCDvs= Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\)) Subject: Re: svn commit: r1711044 - in /httpd/httpd/trunk/modules/http2: h2_io.h h2_mplx.c h2_mplx.h h2_session.c h2_session.h h2_stream.c h2_stream.h h2_task.c h2_task.h h2_task_queue.c h2_task_queue.h h2_version.h From: Stefan Eissing In-Reply-To: <56312A29.7080204@apache.org> Date: Thu, 29 Oct 2015 10:09:31 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <6861A85C-DA34-4A47-9072-E4871FF94E12@greenbytes.de> References: <20151028155307.D89DD3A01A5@svn01-us-west.apache.org> <56312A29.7080204@apache.org> To: dev@httpd.apache.org X-Mailer: Apple Mail (2.3096.5) > Am 28.10.2015 um 21:03 schrieb Ruediger Pluem : > On 10/28/2015 04:53 PM, icing@apache.org wrote: >> [Modified: httpd/httpd/trunk/modules/http2/h2_mplx.c >> URL: = http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_mplx.c?rev= =3D1711044&r1=3D1711043&r2=3D1711044&view=3Ddiff >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- httpd/httpd/trunk/modules/http2/h2_mplx.c (original) >> +++ httpd/httpd/trunk/modules/http2/h2_mplx.c Wed Oct 28 15:53:07 = 2015 >> @@ -128,7 +128,7 @@ h2_mplx *h2_mplx_create(conn_rec *c, apr >>=20 >> m->bucket_alloc =3D apr_bucket_alloc_create(m->pool); >>=20 >> - m->q =3D h2_tq_create(m->id, m->pool); >> + m->q =3D h2_tq_create(m->pool, 23); >=20 > I thought the answer to the last question was 42 :-). Seriously using = a hardcoded value that is not done via a #define > with a descriptive name and that is not documented is IMHO bad. You are correct. I need to give this change a rework anyway, so this = number will disappear. //Stefan=