httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1707159 - /httpd/httpd/trunk/server/eor_bucket.c
Date Wed, 07 Oct 2015 19:10:55 GMT
On Wed, Oct 7, 2015 at 8:45 PM, Ruediger Pluem <rpluem@apache.org> wrote:
>
>
> On 10/07/2015 12:23 AM, ylavic@apache.org wrote:
>>
>>  static void eor_bucket_destroy(void *data)
>>  {
>> -    request_rec *r = (request_rec *)data;
>> +    apr_bucket *h = data;
>
> IMHO this should be
>
> apr_bucket_refcount *h;

Good catch!

Actually, we even need:

typedef struct {
    apr_bucket_refcount refcount;
    request_rec *data;
} apr_bucket_eor;

and use this type everywhere for h.

Thanks,
Yann.

Mime
View raw message