httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Eissing <stefan.eiss...@greenbytes.de>
Subject Re: svn commit: r1711044 - in /httpd/httpd/trunk/modules/http2: h2_io.h h2_mplx.c h2_mplx.h h2_session.c h2_session.h h2_stream.c h2_stream.h h2_task.c h2_task.h h2_task_queue.c h2_task_queue.h h2_version.h
Date Thu, 29 Oct 2015 09:09:31 GMT

> Am 28.10.2015 um 21:03 schrieb Ruediger Pluem <rpluem@apache.org>:
> On 10/28/2015 04:53 PM, icing@apache.org wrote:
>> [Modified: httpd/httpd/trunk/modules/http2/h2_mplx.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_mplx.c?rev=1711044&r1=1711043&r2=1711044&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/http2/h2_mplx.c (original)
>> +++ httpd/httpd/trunk/modules/http2/h2_mplx.c Wed Oct 28 15:53:07 2015
>> @@ -128,7 +128,7 @@ h2_mplx *h2_mplx_create(conn_rec *c, apr
>> 
>>         m->bucket_alloc = apr_bucket_alloc_create(m->pool);
>> 
>> -        m->q = h2_tq_create(m->id, m->pool);
>> +        m->q = h2_tq_create(m->pool, 23);
> 
> I thought the answer to the last question was 42 :-). Seriously using a hardcoded value
that is not done via a #define
> with a descriptive name and that is not documented is IMHO bad.

You are correct. I need to give this change a rework anyway, so this number will disappear.

//Stefan
Mime
View raw message