httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r1711044 - in /httpd/httpd/trunk/modules/http2: h2_io.h h2_mplx.c h2_mplx.h h2_session.c h2_session.h h2_stream.c h2_stream.h h2_task.c h2_task.h h2_task_queue.c h2_task_queue.h h2_version.h
Date Wed, 28 Oct 2015 20:03:53 GMT


On 10/28/2015 04:53 PM, icing@apache.org wrote:
> Author: icing
> Date: Wed Oct 28 15:53:07 2015
> New Revision: 1711044
> 
> URL: http://svn.apache.org/viewvc?rev=1711044&view=rev
> Log:
> http2 priority based scheduling of stream execution in each session
> 
> Modified:
>     httpd/httpd/trunk/modules/http2/h2_io.h
>     httpd/httpd/trunk/modules/http2/h2_mplx.c
>     httpd/httpd/trunk/modules/http2/h2_mplx.h
>     httpd/httpd/trunk/modules/http2/h2_session.c
>     httpd/httpd/trunk/modules/http2/h2_session.h
>     httpd/httpd/trunk/modules/http2/h2_stream.c
>     httpd/httpd/trunk/modules/http2/h2_stream.h
>     httpd/httpd/trunk/modules/http2/h2_task.c
>     httpd/httpd/trunk/modules/http2/h2_task.h
>     httpd/httpd/trunk/modules/http2/h2_task_queue.c
>     httpd/httpd/trunk/modules/http2/h2_task_queue.h
>     httpd/httpd/trunk/modules/http2/h2_version.h
> 
> Modified: httpd/httpd/trunk/modules/http2/h2_io.h

> Modified: httpd/httpd/trunk/modules/http2/h2_mplx.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_mplx.c?rev=1711044&r1=1711043&r2=1711044&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/http2/h2_mplx.c (original)
> +++ httpd/httpd/trunk/modules/http2/h2_mplx.c Wed Oct 28 15:53:07 2015
> @@ -128,7 +128,7 @@ h2_mplx *h2_mplx_create(conn_rec *c, apr
>          
>          m->bucket_alloc = apr_bucket_alloc_create(m->pool);
>          
> -        m->q = h2_tq_create(m->id, m->pool);
> +        m->q = h2_tq_create(m->pool, 23);

I thought the answer to the last question was 42 :-). Seriously using a hardcoded value that
is not done via a #define
with a descriptive name and that is not documented is IMHO bad.

>          m->stream_ios = h2_io_set_create(m->pool);
>          m->ready_ios = h2_io_set_create(m->pool);
>          m->closed = h2_stream_set_create(m->pool);

Regards

RĂ¼diger

Mime
View raw message