httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: Question about CACHE_SEPARATOR in modules/cache/cache_util.h
Date Mon, 26 Oct 2015 12:15:26 GMT
Am 26.10.2015 um 10:11 schrieb Graham Leggett:
> On 26 Oct 2015, at 9:05 AM, Christophe JAILLET <christophe.jaillet@wanadoo.fr>
wrote:
>
>> in modules/cache/cache_util.h, CACHE_SEPARATOR is defined as:
>>
>>      #define CACHE_SEPARATOR ",   "
>>
>>
>> I don't see any reason to have 3 spaces here.
>> It is only used within calls to 'cache_strqtok' and scanning 3 times for the same
thing is just a waste of time.
>>
>> Did I miss something obvious, or can it be turned in:
>>
>>      #define CACHE_SEPARATOR ", “
>
> Double check whether the spaces are significant, it might be a space and a tab (which
would be weird, because it should just say /t then).
>
> This might have RFC compliance issues if it was changed, we need to verify what the code
does.

The line goes back to

https://bz.apache.org/bugzilla/show_bug.cgi?id=50199

where Nick reported the problem and Graham provided the initial patch.

The defined tokenizer chars were "comma-space-space-space" from the 
beginning. But I think Graham pointed into the right direction, probably 
it should have been "comma-space-tab".

Regards,

Rainer

Mime
View raw message