httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Eissing <stefan.eiss...@greenbytes.de>
Subject Re: A small wrinkle in latest r1707735 update to httpd-trunk\modules\http2\h2_util.c
Date Sun, 11 Oct 2015 17:04:26 GMT
Fixed in r1708002.

> Am 10.10.2015 um 22:31 schrieb NormW <normw@gknw.net>:
> 
> On 11/10/2015 4:45 AM, Stefan Eissing wrote:
>> Ok, will add that. This is only in trunk. 2.4.x should compile for you.
> Correct.
> Norm.
>> 
>>> Am 10.10.2015 um 13:31 schrieb NormW <normw@gknw.net>:
>>> 
>>> Hmmmm,
>>>> CC   h2_worker.c
>>>> CC   h2_workers.c
>>>> CC   mod_http2.c
>>>> GEN  obj_release/mod_http2_link.opt
>>>> LINK obj_release/mod_http2.nlm
>>>> ### mwldnlm Linker Error:
>>>> #   Undefined symbol: APR_BUCKET_IS_MMAP in
>>>> #   h2_util.o
>>> 
>>> In apr-util\include\apr_buckets.h:
>>>> #if APR_HAS_MMAP
>>>> /**
>>>> * Determine if a bucket is a MMAP bucket
>>>> * @param e The bucket to inspect
>>>> * @return true or false
>>>> */
>>>> #define APR_BUCKET_IS_MMAP(e)        ((e)->type == &apr_bucket_type_mmap)
>>>> #endif
>>> 
>>> :-( MMAP is (sadly) not a feature of NetWare. If the http2 experts assert the
entire http2 module is a dud without MMAP support, I am not in a position or mind to oppose
dropping NetWare 'support' for http2 entirely.
>>> 
>>> Alternatively, something like this in h2_util.c MAY be good enough :
>>>>                }
>>>> ++ #if APR_HAS_MMAP
>>>>                else if (APR_BUCKET_IS_MMAP(b)) {
>>>>                    btype = "mmap";
>>>>                }
>>>> ++ #endif
>>> 
>>> Norm
>> 
> 


Mime
View raw message