Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <AB1691BE05AE7F4992697F2A0835627AC6318B25@VOEXM10W.internal.vodafone.com>
References: <55f932e5.7c4.be8.3af5@land10.nl>
	<AB1691BE05AE7F4992697F2A0835627AC6318B25@VOEXM10W.internal.vodafone.com>
Date: Wed, 16 Sep 2015 11:36:10 +0200
Message-ID: 
 <CAKQ1sVNO834LqxxQLvkGp9jtBS3G2Q6dpeoMf8==fiGN6y-bMQ@mail.gmail.com>
Subject: Re: 2.4.17-protocols-http2/ - SNI issue
From: Yann Ylavic <ylavic.dev@gmail.com>
To: dev@httpd.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 16, 2015 at 11:24 AM, Pl=C3=BCm, R=C3=BCdiger, Vodafone Group
<ruediger.pluem@vodafone.com> wrote:
>
>> -----Original Message-----
>> From: Steffen
>> Sent: Mittwoch, 16. September 2015 11:14
>> To: dev@httpd.apache.org
>> Subject: 2.4.17-protocols-http2/ - SNI issue
[]
>>
>> [ssl:error] [pid 3428:tid 3952] AH02032: Hostname www.apachelounge.com
>> provided via SNI and hostname www.apachelounge.com provided via HTTP
>> are different
>
> The above is very weird as both times we see www.apachelounge.com. Can yo=
u please check the logs with some kind of hex tool if there is really no di=
fference between both strings? The logic to detect a difference in the code=
 is just a usual strcasecmp. So I sense some hidden characters somewhere, w=
hich might give us a hint where things go really wrong.

ISTM that the test should be:
            if (strcasecmp(host, servername)
                || (sslconn->server
                    && !ssl_util_vhost_matches(host, sslconn->server)))

instead of:
           if (strcasecmp(host, servername)
                || !sslconn->server
                || !ssl_util_vhost_matches(host, sslconn->server))

Not sure sslconn->server isn't NULL here for the first request.

Regards,
Yann.