httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Eissing <stefan.eiss...@greenbytes.de>
Subject Re: svn commit: r1705257 - /httpd/httpd/trunk/modules/http2/config.m4
Date Fri, 25 Sep 2015 09:31:42 GMT
Ah, understood. Thanks!

But would it then not make more sense to have both --enable-* do:

> APACHE_MODULE(h2,

since there is no modules named "http2"?

> Am 25.09.2015 um 11:23 schrieb Ruediger Pluem <rpluem@apache.org>:
> 
> 
> 
> On 09/25/2015 10:58 AM, Stefan Eissing wrote:
>> Me not fully understand. Why at all and why only there? (curiousity)
> 
> Because it tries to build mod_h2 even if nghttp2 is not present.
> 
> Because
> 
> APACHE_MODULE(http2,
> 
> and
> 
> APACHE_MODULE(h2,
> 
> effectively setup two distinct modules with the same object files (h2_objs)
> 
> and if you do not set enable_http2 / enable_h2 to no the objects will be build even if
not explicitly asked for because
> they belong to most and I configure with --enable-mods-shared=all.
> 
> This worked fine before we had this 2 name approach. It will be interesting to see what
it does if nghttp2 is present
> as it likely tries to build and enable mod_http2 and mod_h2. I guess building will work
due to the fact that it just
> compiles h2_objs twice, but I guess we will have two LoadModule directives in the resulting
httpd.conf:
> One for mod_http2 and one for mod_h2.
> 
> Regards
> 
> Rüdiger
> 
>> 
>>> Am 25.09.2015 um 10:54 schrieb rpluem@apache.org:
>>> 
>>> Author: rpluem
>>> Date: Fri Sep 25 08:54:38 2015
>>> New Revision: 1705257
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=1705257&view=rev
>>> Log:
>>> * Disable the http2 modules if nghttp2 is not present
>>> 
>>> Modified:
>>>   httpd/httpd/trunk/modules/http2/config.m4
>>> 
>>> Modified: httpd/httpd/trunk/modules/http2/config.m4
>>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/config.m4?rev=1705257&r1=1705256&r2=1705257&view=diff
>>> ==============================================================================
>>> --- httpd/httpd/trunk/modules/http2/config.m4 (original)
>>> +++ httpd/httpd/trunk/modules/http2/config.m4 Fri Sep 25 08:54:38 2015
>>> @@ -181,7 +181,7 @@ is usually linked shared and requires lo
>>>           APR_ADDTO(MOD_H2_LDADD, [-export-symbols-regex h2_module])
>>>        fi
>>>    else
>>> -        enable_h2=no
>>> +        enable_http2=no
>>>    fi
>>> ])
>>> APACHE_MODULE(h2, [HTTP/2 support (Deprecated. Use --enable-http2)], $h2_objs,
, most, [
>>> 
>>> 
>> 
>> 

<green/>bytes GmbH
Hafenweg 16, 48155 Münster, Germany
Phone: +49 251 2807760. Amtsgericht Münster: HRB5782




Mime
View raw message