httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NormW <no...@gknw.net>
Subject Re: r1701005 httpd-trunk\server\protocols.c
Date Fri, 04 Sep 2015 04:23:35 GMT
On 4/09/2015 9:05 AM, Yann Ylavic wrote:
> On Fri, Sep 4, 2015 at 12:52 AM, NormW <normw@gknw.net> wrote:
>> Hi again,
>> Pushing passed previous problem, now arrive at:
>>>
>>> D:\Projects\svn\httpd-trunk\server>svn diff
>>> Index: protocol.c
>>> ===================================================================
>>> --- protocol.c  (revision 1701142)
>>> +++ protocol.c  (working copy)
>>> @@ -1981,10 +1981,10 @@
>>>                                               server_rec *s,
>>>                                               apr_array_header_t *choices)
>>>   {
>>> +    apr_array_header_t *proposals;
>>>       apr_pool_t *pool = r? r->pool : c->pool;
>>>       core_server_config *conf =
>>> ap_get_core_module_config(s->module_config);
>>>       const char *protocol = NULL, *existing = ap_get_protocol(c);;
>>> -    apr_array_header_t *proposals;
>
> Hm, aren't there other/many places in the httpd code where non
> initialized variables are declared after the initialized ones?
>
I am hoping my compiler is at least consistent!
Not sure of what the rules are well enough to be an expert. I know 
Windows can be as pedantic as mine. See if Gregg asks for a similar 
change first, just to be sure.
Norm


Mime
View raw message