Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
To: dev@httpd.apache.org
From: NormW <normw@gknw.net>
Subject: C89-ify a recent change to h2_io_set.c
Message-ID: <55D4530B.8000901@gknw.net>
Date: Wed, 19 Aug 2015 19:57:31 +1000
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

G/Evening (Is here)
A very small tweak is proposed for:
  httpd-trunk\modules\http2\h2_io_set.c
to keep the C89-ers in their seats.

The svn diff looks like:
Index: modules/http2/h2_io_set.c
===================================================================
--- modules/http2/h2_io_set.c   (revision 1696548)
+++ modules/http2/h2_io_set.c   (working copy)
@@ -67,12 +67,13 @@
      /* we keep the array sorted by id, so lookup can be done
       * by bsearch.
       */
+    h2_io **ps;
      h2_io key;
      h2_io *pkey = &key;

      memset(&key, 0, sizeof(key));
      key.id = stream_id;
-    h2_io **ps = bsearch(&pkey, sp->list->elts, sp->list->nelts,
+    ps = bsearch(&pkey, sp->list->elts, sp->list->nelts,
                           sp->list->elt_size, h2_stream_id_cmp);
      return ps? *ps : NULL;
  }

I won't bore anyone who can follow that module with a patch.
Cheers,
Norm