Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Message-ID: <55C8F3FA.8050302@gknw.net>
Date: Mon, 10 Aug 2015 11:56:58 -0700
From: Gregg Smith <gls@gknw.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US;
 rv:1.9.2.28) Gecko/20120306 Thunderbird/3.1.20
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: svn commit: r1694950 - in /httpd/httpd/trunk:
 include/http_request.h
 modules/http/http_request.c
References: <20150810033025.E37D4AC0095@hades.apache.org>
	<55C83953.1000904@wanadoo.fr>	<55C8DFF9.3070400@gknw.net>
 <CACsi2502KGeb-KPjDuAVwdALubzb8vgfgewVayurv5OGnYUO+Q@mail.gmail.com>
In-Reply-To: 
 <CACsi2502KGeb-KPjDuAVwdALubzb8vgfgewVayurv5OGnYUO+Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 8/10/2015 11:44 AM, William A Rowe Jr wrote:
> On Mon, Aug 10, 2015 at 12:31 PM, Gregg Smith<gls@gknw.net>  wrote:
>
>> Hi,
>>
>> I guess a minor at least.
>>
>> I did not add, remove or change the structure of the function, I simply
>> made it available to modules. Does that warrant a major bump?
>>
> Never a major - that is reserved for changing the signature of functions
> or members of structures that are catastrophic for previously compiled
> modules.  This is not one of those :)
>
> The previous absence of these exports was simply a bug, I don't see
> a reason to bump the version minor for bug fixing.
>
> If users were looking to determine compatibility, e.g. on the 2.4 released
> branch, I might have another opinion, but during trunk development, we
> fix it and move on.  A previously compiled module simply wouldn't have
> any insight on these functions so correcting it doesn't break what they
> were already aware of

Thanks Christophe for bringing it up.
Thanks Bill and Rüdiger for the answer. I was sure it was not a major 
bump yet was foggy on the minor. My feeling on it was as Bill stated in 
his last sentence above.

G