httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Eissing <stefan.eiss...@greenbytes.de>
Subject Re: svn commit: r1696592 - in /httpd/httpd/trunk/modules/http2: h2_alt_svc.c h2_conn.c h2_from_h1.c h2_request.c h2_switch.c
Date Wed, 19 Aug 2015 14:56:33 GMT

> Am 19.08.2015 um 16:37 schrieb William A Rowe Jr <wrowe@rowe-clan.net>:
>  h2_alt_svc *h2_alt_svc_parse(const char *s, apr_pool_t *pool) {
> -    const char *sep = strchr(s, '=');
> +    const char *sep = strchr((char *)s, '=');
> 
> 
> We solve these issues with ap_strchr_c, ap_strrchr_c, ap_strstr_c etc.  This avoids the
casts, which are always worth avoiding for other analysis tools and inadvertent overwriting.

I live to learn. Changed in r1696607.

<green/>bytes GmbH
Hafenweg 16, 48155 Münster, Germany
Phone: +49 251 2807760. Amtsgericht Münster: HRB5782




Mime
View raw message