httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <...@apache.org>
Subject Re: svn commit: r1697322 - /httpd/httpd/branches/2.4.x/STATUS
Date Mon, 24 Aug 2015 11:20:21 GMT
On Mon, 24 Aug 2015 07:40:33 -0000
rpluem@apache.org wrote:

> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Mon Aug 24 07:40:33 2015
> @@ -238,8 +238,15 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>        +1: rpluem, ylavic
>        niq: 1. the if(worker->s->retries) {} and comment at line 2917
>                don't seem to make any sense.
> +      rpluem: This is just taken over from existing code. It is just indented
> +              differently hence part of the path I think it should be marked
> +              as TODO section. But this should be subject to another
> +              patch.

Agreed it comes from existing code, but I wonder if its meaning and purpose
haven't got lost since it was originally written?

I'm +1 if that's either removed or if the comment clarifies what
actual case the TODO would be dealing with.

-- 
Nick Kew

Mime
View raw message