httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, Vodafone Group <ruediger.pl...@vodafone.com>
Subject RE: [VOTE] Release Apache httpd 2.4.15 as GA
Date Mon, 22 Jun 2015 08:50:18 GMT


> -----Original Message-----
> From: Eric Covener [mailto:covener@gmail.com]
> Sent: Montag, 22. Juni 2015 01:08
> To: Apache HTTP Server Development List
> Subject: Re: [VOTE] Release Apache httpd 2.4.15 as GA
> 
> On Sun, Jun 21, 2015 at 5:24 PM, William A Rowe Jr <wrowe@rowe-clan.net>
> wrote:
> > As this is not a regression from 2.4.13 or 2.4.14 candidates, it seems
> to me
> > we should ship.
> 
> I am -1 for 2.4.15 with the regression.  The other candidates being
> broken doesn't mitigate it much for me.

+1 to Eric's comment and
-1 from me as well on the release. Looks like we are a little bit out of luck with 2.4.x releases
recently :-).
My proposal is to leave the vote open at most for 24 hours to see if anything more comes up
and then roll 2.4.16
with the patch from Yann applied.
@Yann: Wouldn't it make sense to check for cmd->path as well before we do the expression
parsing stuff to ensure we are really in a <Location...> section?

So something like:

@@ -270,7 +273,7 @@
      * if we understand the first arg but have no second arg, we are dealing
      * with a status like "GONE".
      */
-    if (grokarg1 && arg2 && !arg3 && HTTP_GONE != status) {
+    if (grokarg1 > 0 && arg2 && !arg3 && cmd->path &&
HTTP_GONE != status) {
         const char *expr_err = NULL;
 
         dirconf->redirect =

Regards

Rüdiger

Mime
View raw message