Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: message received from 54.164.171.186
 which is an MX secondary for dev@httpd.apache.org)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
Subject: Re: ALPN patch comments
From: Jim Jagielski <jim@jaguNET.com>
In-Reply-To: <5540BB0D.7070808@velox.ch>
Date: Wed, 29 Apr 2015 08:24:22 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <651355DD-D5A4-4D7C-B81B-B4D31FC4DECB@jaguNET.com>
References: <E0A3DDFB-10EA-4234-B421-7B5AAB2BF2C1@greenbytes.de>
 <5537C311.6020209@velox.ch>
 <40445687-9A14-4DDD-89A0-0B752E7CDC0B@jaguNET.com>
 <553B62C2.9080202@velox.ch>
 <D0F6D103-F293-4BCE-8213-0F0A1148FC26@greenbytes.de>
 <5540BB0D.7070808@velox.ch>
To: dev@httpd.apache.org

Thank You!!

Will review ASAP.

> On Apr 29, 2015, at 7:05 AM, Kaspar Brand <httpd-dev.2014@velox.ch> =
wrote:
>=20
> On 27.04.2015 17:04, Stefan Eissing wrote:
>>> Am 25.04.2015 um 11:47 schrieb Kaspar Brand =
<httpd-dev.2014@velox.ch>:
>>> Only tested in terms of "compiles both w/ and w/o HAVE_TLS_ALPN", so =
it
>>> certainly needs more eyes before a backport proposal could be made.
>>> There's also a "TODO: we should have a mod_ssl configuration =
parameter"
>>> in ssl_engine_kernel.c which I'm unsure to what it refers.
>>=20
>> The =E2=80=9ETODO=E2=80=9C is a leftover from before =
SSLAlpnPreference was introduced.
>> It can be removed.
>=20
> I did some formatting cleanup in r1676709 and put a patch for 2.4.x
> online under
> https://people.apache.org/~kbrand/mod_ssl-2.4.x-alpn_2015-04-29.diff.
> This should hopefully make it easier for people to test and review =
(it's
> an amalgamation of ten revisions from trunk, see the top of the patch =
file).
>=20
> Kaspar