httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: ALPN patch comments
Date Thu, 23 Apr 2015 07:34:04 GMT
Am 23.04.2015 um 06:56 schrieb Kaspar Brand:
> On 22.04.2015 21:30, Rainer Jung wrote:
>> Am 22.04.2015 um 17:49 schrieb Kaspar Brand:
>>> Thanks. In the patch for ssl_private.h, the complete NPN block should
>>> actually be dropped - the same block is are already part of
>>> ssl_private.h, just 10 lines above.
>>
>> I've kept the new one and dropped the old one in r1675459.
>
> It's nitpicking, but... the old one was already correct, actually. All
> this stuff is in a larger "#if !defined(OPENSSL_NO_TLSEXT) ..." block,
> so there's no need to repeat NO_TLSEXT.

Oups, fixed in r1675549.

> I'd rather get consensus on completely dropping HAVE_TLS_NPN from trunk
> anyway, though, so it's really a very minor point right now ;-)

Agreed.

Rainer


Mime
View raw message