httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christophe JAILLET <christophe.jail...@wanadoo.fr>
Subject Re: svn commit: r1585609 - /httpd/httpd/trunk/modules/aaa/mod_authz_core.c
Date Fri, 17 Apr 2015 20:45:16 GMT
Hi,

I would +1 for this solution which is, IMHO, much better.
However, changing the parser itself would require checking the potential 
impact as it is used in many places.

CJ

Le 17/04/2015 13:15, Yann Ylavic a écrit :
> On Fri, Apr 17, 2015 at 11:54 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
>> How about handling the case in the Require directive parser itself
>> (add_authz_provider)?
> Or even maybe in the expr parser itself:
>
> Index: server/util_expr_eval.c
> ===================================================================
> --- server/util_expr_eval.c    (revision 1674046)
> +++ server/util_expr_eval.c    (working copy)
> @@ -455,6 +455,10 @@ AP_DECLARE(ap_expr_info_t*) ap_expr_parse_cmd_mi(c
>       info->line_number = cmd->directive->line_num;
>       info->flags = flags;
>       info->module_index = module_index;
> +    if (expr && (expr[0] == '"' || expr[0] == '\'') && (expr[1] != '\0')
> +             && (expr[strlen(expr) - 1] == expr[0])) {
> +        expr = ap_getword_conf(cmd->temp_pool, &expr);
> +    }
>       *err = ap_expr_parse(cmd->pool, cmd->temp_pool, info, expr, lookup_fn);
>
>       if (*err)
> --
>


Mime
View raw message