httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors
Date Wed, 18 Mar 2015 10:07:23 GMT
Corresponding patch attached...

On Wed, Mar 18, 2015 at 10:57 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
> On Wed, Mar 18, 2015 at 10:44 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
>>
> []
>> Index: modules/proxy/mod_proxy_wstunnel.c
>> ===================================================================
>> --- modules/proxy/mod_proxy_wstunnel.c    (revision 1665828)
>> +++ modules/proxy/mod_proxy_wstunnel.c    (working copy)
> []
>> @@ -292,7 +299,15 @@ static int proxy_wstunnel_request(apr_pool_t *p, r
>>      ap_log_rerror(APLOG_MARK, APLOG_TRACE2, 0, r,
>>                    "finished with poll() - cleaning up");
>>
>> -    return OK;
>> +    if (!response_sent) {
>> +        return HTTP_BAD_GATEWAY;
>> +    }
>> +    else if (!request_sent) {
>> +        return HTTP_BAD_REQUEST;
>
> This case is probably not a good idea, so we'd better not handle
> request_sent at all (only response_sent), and use NULL instead for
> proxy_wstunnel_transfer().
>
>> +    }
>> +    else {
>> +        return OK;
>> +    }
>>  }
>>
>>  /*
>> --

Mime
View raw message