httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors
Date Tue, 17 Mar 2015 12:23:44 GMT
On Tue, Mar 17, 2015 at 12:38 PM, Jan Kalu┼ża <jkaluza@redhat.com> wrote:
> Hi,
>
> I have found out that when WSS is used and SSL handshake fails, httpd closes
> client connection without any response to the client.

If the SSL handshake fails, there is no SSL established connection
which we can send an HTTP response on.
We can only send an SSL alert in this case, and I think mod_ssl takes
care of this already (this occurs while reading the request header,
before mod_proxy_wstunnel IMHO).

>
> In the log, one can see following:
>
> mod_proxy_wstunnel.c(131): (103)Software caused connection abort: [client
> 127.0.0.1:49915] AH02442: error on sock - ap_get_brigade
>
> Attached patch against 2.4.x fixes it. I'm not committing it, because this
> problem has been introduced in r1493741 and seems like intentional thing.
> This commit has been reverted in r1605946, so my theory is that this
> particular part of mod_proxy_wstunnel has not been reverted completely, but
> I want to be sure before I commit/propose.

One the Upgrade is done, I don't think we can respond with 500 (in the
poll()ing phase, this is no more HTTP).
AFAICT r1605946 did nor revert r1493741, and I think this rather comes
for https://bz.apache.org/bugzilla/show_bug.cgi?id=56299#c7.

Regards,
Yann.

Mime
View raw message