httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christophe JAILLET <christophe.jail...@wanadoo.fr>
Subject Re: svn commit: r1440055 - /httpd/httpd/trunk/docs/manual/expr.xml
Date Mon, 05 Jan 2015 20:21:08 GMT
Hi,

while looking at comment 
http://httpd.apache.org/docs/2.4/en/expr.html#comment_779 and responses 
in order to fix doc if needed, I arrived at the below commit which 
already adds this "v" function.

However, looking at the code in "util_expr_eval.c" and "mod_include.c", 
I'm note sure that this doc fix is correct. According to my analysis, 
this "v" shortcut is only available within mod_include and is not 
available elsewhere. See function "include_expr_lookup" in "mod_include" 
and the "string_func_providers" table in "util_expr_eval.c"

So I think that this commit should be reverted or at least tweaked to 
state that this short-cut is not available everywhere.

Do you share my analysis ?

Best regards.
CJ



Le 29/01/2013 19:51, humbedooh@apache.org a écrit :
> Author: humbedooh
> Date: Tue Jan 29 18:51:56 2013
> New Revision: 1440055
>
> URL: http://svn.apache.org/viewvc?rev=1440055&view=rev
> Log:
> Note that v is a shortcut for reqenv
>
> Modified:
>      httpd/httpd/trunk/docs/manual/expr.xml
>
> Modified: httpd/httpd/trunk/docs/manual/expr.xml
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/expr.xml?rev=1440055&r1=1440054&r2=1440055&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/docs/manual/expr.xml (original)
> +++ httpd/httpd/trunk/docs/manual/expr.xml Tue Jan 29 18:51:56 2013
> @@ -455,7 +455,7 @@ listfunction ::= listfuncname "<strong>(
>       <tr><td><code>resp</code></td>
>           <td>Get HTTP response header</td><td></td></tr>
>       <tr><td><code>reqenv</code></td>
> -        <td>Lookup request environment variable</td><td></td></tr>
> +        <td>Lookup request environment variable (as a shortcut, <code>v</code>
can be used too to access variables).</td><td></td></tr>
>       <tr><td><code>osenv</code></td>
>           <td>Lookup operating system environment variable</td><td></td></tr>
>       <tr><td><code>note</code></td>
>


Mime
View raw message