Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C045C10404 for ; Fri, 5 Dec 2014 12:47:47 +0000 (UTC) Received: (qmail 6451 invoked by uid 500); 5 Dec 2014 12:47:47 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 6377 invoked by uid 500); 5 Dec 2014 12:47:47 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 6367 invoked by uid 99); 5 Dec 2014 12:47:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Dec 2014 12:47:47 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of trawick@gmail.com designates 209.85.215.53 as permitted sender) Received: from [209.85.215.53] (HELO mail-la0-f53.google.com) (209.85.215.53) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Dec 2014 12:47:21 +0000 Received: by mail-la0-f53.google.com with SMTP id gm9so574722lab.26 for ; Fri, 05 Dec 2014 04:45:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=OtmcYRJyBKi3Xeb2voQ9/zYcT9weWbiGVgcgP4BU6aE=; b=YRWriFQ2dvUASXVM6LkYFpQZEwqHwzprucihJpboQTAQmPzEYqh19K6CZD0mBfwEPX Yi0syuYLk3OPOr5KOBEdV6MnJvH18N50pSkxKPEFNMk5/ZjfAoYxtprqdKfkoCmTH0OD FI1OXyEjrehRpBLEUyiHr/UMma5ckx/4gqBcz5IfB6JxAa5IrOoSLoeoKveVCPcSjOoU u2UGQXoHNcwT+A3RXgkpCwoPtjS/2rX2ZIltA6DMa5bcCuniYAmhMc0ppVYn+VuApQkP 9SFleNqyZcihwQiN8HG+LJi06C/iwvRkkwiQzsxijViX3lpo2RtSw2FsZ9mvLiqW1a6H Qg6w== MIME-Version: 1.0 X-Received: by 10.112.27.133 with SMTP id t5mr2704645lbg.45.1417783550723; Fri, 05 Dec 2014 04:45:50 -0800 (PST) Received: by 10.114.3.5 with HTTP; Fri, 5 Dec 2014 04:45:50 -0800 (PST) In-Reply-To: References: Date: Fri, 5 Dec 2014 07:45:50 -0500 Message-ID: Subject: Re: mod_proxy_fcgi issues From: Jeff Trawick To: Apache HTTP Server Development List Content-Type: multipart/alternative; boundary=001a1133b04ae8cc0a05097774cb X-Virus-Checked: Checked by ClamAV on apache.org --001a1133b04ae8cc0a05097774cb Content-Type: text/plain; charset=UTF-8 On Thu, Dec 4, 2014 at 11:50 AM, Jeff Trawick wrote: > On Thu, Dec 4, 2014 at 10:38 AM, Eric Covener wrote: > >> forked from apachecon thread >> >> On Thu, Dec 4, 2014 at 10:23 AM, Jeff Trawick wrote: >> > On Thu, Dec 4, 2014 at 9:58 AM, Eric Covener wrote: >> >> >> >> On Tue, Dec 2, 2014 at 4:14 PM, Jim Riggs >> wrote: >> >> > P.S. mod_proxy_balancer -> mod_proxy_fcgi -> php-fpm is really fun >> and >> >> > interesting too! ;-) >> >> >> >> mod_proxy_fcgi seems to need a bit of work from what I have been >> >> seeing in bugzilla and IRC. I hope to spend a little time on the code >> >> and doc, but not being an actual user of it I don't know how far I >> >> will really get before being distracted. >> > >> > >> > This is very important stuff IMO. >> > >> > I know we don't do the coordination thing around here, but if the work >> was >> > organized to some extent, perhaps 3-4 people could easily share the >> work??? >> > (bite sized chunks of the development: simple reproducers, doc, code, >> > review, whatever) >> > >> > Besides searching through Bugzilla and summarizing each mod_proxy_fcgi >> bug >> > and ranking by apparent severity, number of users involved in the bug >> > discussion, etc., what else should I put on a Wiki page? E.g., do you >> have >> > an idea of what needs to be improved in the doc? >> >> I don't have much more than what amounts to the summary/initial poking >> around in the bugzillas. I had the wiki thought too -- bullets there >> are much easie than trying to reabsorb the PRs each time. >> >> - examples need to account for php-fpm (how URLs and or paths are passed) >> - fixes for CGI variables in different configurations (sethandler vs. >> proxypass) >> -- fixup r->filename right before adding CGI vars, maybe directory walk >> -- path info calculation probably needs multiple modes. Maybe expr based? >> > > FWIW, every time I see the PATH_INFO questions I recall the nginx > configuration (the script vars provided are those defined in the > configuration, with some expression support); we need general CGISetVar > that sets or overrides script variables in common code (like > CGIPassAuth) so that it works with the many modules that interface with > scripts. > > > >> - further doc for worker matching stuff with ProxySet >> - provide a convenience/less verbose directive to configure SetHandler >> + a backend worker >> -- doc SetHandler advantages >> - change compile-time diag stuff to trace8 >> - need to port mod_proxy_http or mod_fcgid body spooling / content >> length passing >> - would be nice to have a non php-fpm fastcgi server to sanity check >> with so we don't end up with too many php-fpm-isms >> - figure out / make sure balancer examples work with php-fpm and/or >> setHandler >> > > And although mod_proxy_fcgi is the usual suspect, some of these are > important issues with mod_proxy_scgi too. (It is faster, and for some > deployments there's no natural preference for FastCGI over SCGI.) > > Thanks for all the notes; I'll write this stuff up today. > > Initial version at https://wiki.apache.org/httpd/Development/mod_proxy_fcgi I haven't integrated your list into the table yet -- Born in Roswell... married an alien... http://emptyhammock.com/ --001a1133b04ae8cc0a05097774cb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On T= hu, Dec 4, 2014 at 11:50 AM, Jeff Trawick <trawick@gmail.com> wrote:
On Thu, Dec 4= , 2014 at 10:38 AM, Eric Covener <covener@gmail.com> wrote:<= br>
forked from apachecon thread

On Thu, Dec 4, 2014 at 10:23 AM, Jeff Trawick <trawick@gmail.com> wrote:
> On Thu, Dec 4, 2014 at 9:58 AM, Eric Covener <covener@gmail.com> wrote:
>>
>> On Tue, Dec 2, 2014 at 4:14 PM, Jim Riggs <apache-lists@riggs.me> wrote:=
>> > P.S. mod_proxy_balancer -> mod_proxy_fcgi -> php-fpm is= really fun and
>> > interesting too! ;-)
>>
>> mod_proxy_fcgi seems to need a bit of work from what I have been >> seeing in bugzilla and IRC.=C2=A0 I hope to spend a little time on= the code
>> and doc, but not being an actual user of it I don't know how f= ar I
>> will really get before being distracted.
>
>
> This is very important stuff IMO.
>
> I know we don't do the coordination thing around here, but if the = work was
> organized to some extent, perhaps 3-4 people could easily share the wo= rk???
> (bite sized chunks of the development:=C2=A0 simple reproducers, doc, = code,
> review, whatever)
>
> Besides searching through Bugzilla and summarizing each mod_proxy_fcgi= bug
> and ranking by apparent severity, number of users involved in the bug<= br> > discussion, etc., what else should I put on a Wiki page?=C2=A0 E.g., d= o you have
> an idea of what needs to be improved in the doc?

I don't have much more than what amounts to the summary/initial poking<= br> around in the bugzillas.=C2=A0 I had the wiki thought too -- bullets there<= br> are much easie than trying to reabsorb the PRs each time.

- examples need to account for php-fpm (how URLs and or paths are passed) - fixes for CGI variables in different configurations (sethandler vs. proxy= pass)
-- fixup r->filename right before adding CGI vars, maybe directory walk<= br> -- path info calculation probably needs multiple modes.=C2=A0 Maybe expr ba= sed?

FWIW, every time I see= the PATH_INFO questions I recall the nginx configuration (the script vars = provided are those defined in the configuration, with some expression suppo= rt); we need general CGISetVar <var> <expr> that sets or overri= des script variables in common code (like CGIPassAuth) so that it works wit= h the many modules that interface with scripts.
=
=C2=A0
- further doc for worker matching stuff with ProxySet
- provide a convenience/less verbose directive to configure SetHandler
+=C2=A0 a backend worker
-- doc SetHandler advantages
- change compile-time diag stuff to trace8
- need to port mod_proxy_http or mod_fcgid body spooling / content
length passing
- would be nice to have a non php-fpm fastcgi server to sanity check
with so we don't end up with too many php-fpm-isms
- figure out / make sure balancer examples work with php-fpm and/or setHand= ler

And although mod_proxy_fcgi is =C2=A0the usua= l suspect, some of these are important issues with mod_proxy_scgi too. =C2= =A0(It is faster, and for some deployments there's no natural preferenc= e for FastCGI over SCGI.)

Thanks for a= ll the notes; I'll write this stuff up today.



I haven't integ= rated your list into the table yet
--
Born in Roswell... married an alien...
http://emptyhammock.com/

--001a1133b04ae8cc0a05097774cb--