httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: [Patch] mod_crypto: A general purpose crypto filter with HLS support
Date Tue, 09 Dec 2014 22:03:32 GMT
On Tue, Dec 9, 2014 at 10:56 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
> +static apr_status_t crypto_in_filter(ap_filter_t *f, apr_bucket_brigade *bb,
> +        ap_input_mode_t mode, apr_read_type_e block, apr_off_t readbytes)
> +{
[]
> +    /* if our buffer is empty, read off the network until the buffer is full */
> +    if (APR_BRIGADE_EMPTY(ctx->bb)) {
[]
> +        while (!ctx->seen_eos && ctx->remaining > 0) {
> +            const char *data;
> +            apr_size_t size = 0;
> +

Also I think we should :
            apr_brigade_cleanup(ctx->tmp);
here.

> +            rv = ap_get_brigade(f->next, ctx->tmp, mode, block,
> ctx->remaining);
> +

Mime
View raw message