httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Kalu┼ża <jkal...@redhat.com>
Subject PR 53435, r101624, mod_ssl: error strings can't be loaded again once?
Date Tue, 11 Nov 2014 13:32:20 GMT
Hi,

latest comment in PR 53435 shows that memory leak in mod_ssl which 
happens during graceful restarts can be caused by r101624. Since this 
commit is 11 years old, I wanted to ask people here, if following is 
still true with current OpenSSL:

> @@ -255,7 +255,11 @@ static apr_status_t ssl_cleanup_pre_config(void *data)
> #endif
> #endif
> ERR_remove_state(0);
> - ERR_free_strings();
> +
> + /* Don't call ERR_free_strings here; ERR_load_*_strings only
> + * actually load the error strings once per process due to static
> + * variable abuse in OpenSSL. */
> +
> /*
> * TODO: determine somewhere we can safely shove out diagnostics
> * (when enabled) at this late stage in the game:

Last comment in PR 53435 showed that leaks disappeared after reverting 
this patch and it does not seem to break anything here.

Regards,
Jan Kaluza

Mime
View raw message