Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of apache-dev@m.gmane.org
 designates 80.91.229.3 as permitted sender)
To: dev@httpd.apache.org
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: Why does .indent.pro not really resemble our style?
Date: Sat, 04 Oct 2014 08:57:23 +0200
Lines: 34
Message-ID: <m0o5ol$qs8$1@ger.gmane.org>
References: 
 <CALK=YjOgBFMy_F+f-Op0hB5fWN=VD63aPFL9=gPQaMqPMxqOzw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.1.2
In-Reply-To: 
 <CALK=YjOgBFMy_F+f-Op0hB5fWN=VD63aPFL9=gPQaMqPMxqOzw@mail.gmail.com>

Le 01/07/2014 02:54, Eric Covener a écrit :
> Why does .indent.pro all over the tree not really resemble our style
> too closely?  If I re-indent any file, lots of stuff is changed (*
> operator, any struct, etc).    A good example is mod_setenvif.c

According to http://httpd.apache.org/dev/styleguide.html, only -nut 
seems to be missing. Without it, spaces are turned into tabs.

In order to have less "* operator" changes, -T apparently needs to be 
used. I added -Tapr_pool_t in .indent.pro in modules/metadata and it 
removed a few of them.
But IMHO, having to manage manually the list of these -T would be a 
nightmare.


Moreover, most of the directories don't have .indent.pro file.
I've found only 17.


Finally, changes made by indent are not always accurate. Options should 
maybe be tweaked to get a slightly better output but manual review of 
changes is still needed.


In order to ease the use of indent all over the tree, we could:
     - remove .indent.pro files
     - keep only one in the root directory, add the missing -nut (and 
tweak it with some useful -T entries)
     - document how to use |INDENT_PROFILE for users that want to use 
indent, OR
      that the .indent.pro file has to be copied in their home directory

CJ
|