httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1629372 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number modules/ssl/ssl_engine_init.c modules/ssl/ssl_private.h modules/ssl/ssl_util_stapling.c
Date Sun, 05 Oct 2014 11:55:19 GMT
On Sat, Oct 4, 2014 at 12:58 PM,  <kbrand@apache.org> wrote:
> Author: kbrand
> Date: Sat Oct  4 10:58:49 2014
> New Revision: 1629372
>
> URL: http://svn.apache.org/r1629372
[...]
>
> Modified:
[...]
>     httpd/httpd/trunk/modules/ssl/ssl_util_stapling.c
>
[...]
> Modified: httpd/httpd/trunk/modules/ssl/ssl_util_stapling.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/ssl_util_stapling.c?rev=1629372&r1=1629371&r2=1629372&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/ssl/ssl_util_stapling.c (original)
> +++ httpd/httpd/trunk/modules/ssl/ssl_util_stapling.c Sat Oct  4 10:58:49 2014
[...]
> @@ -106,70 +102,96 @@ static X509 *stapling_get_issuer(modssl_
[...]
> +
> +    /* At this point, we have determined that there's something to store */
> +    cinf = apr_pcalloc(p, sizeof(certinfo));
> +    memcpy (cinf->idx, idx, sizeof(idx));
> +    cinf->cid = cid;
> +    /* make sure cid is also freed at pool cleanup */
> +    apr_pool_cleanup_register(p, cid, ssl_stapling_certid_free,
> +                              apr_pool_cleanup_null);
> +    if (aia) {
> +       /* allocate uri from the pconf pool */
> +       cinf->uri = apr_pstrdup(p, sk_OPENSSL_STRING_value(aia, 0));

sk_OPENSSL_STRING_value() is undefined in openssl-0.9.8x, I commited a
follow up in r1629485.
Can you please check this is the right thing to do?

> +       X509_email_free(aia);
> +    }
[...]

Regards,
Yann.

Mime
View raw message