httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1599531 - in /httpd/httpd/trunk: CHANGES include/ap_listen.h server/listen.c server/mpm/event/event.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c server/mpm_unix.c
Date Sun, 05 Oct 2014 19:20:22 GMT
Hi Yingqi,

On Sun, Oct 5, 2014 at 8:38 PM, Lu, Yingqi <yingqi.lu@intel.com> wrote:
> Here (attachment) is the most recent version of the fix. It fixes a small
> issue for event mpm in the version I sent out yesterday. Please use this
> one as the final fix. I have already updated the Bugzilla database for
> "Bug 55897 - [PATCH]patch with SO_REUSEPORT support"
>

I don't think we can use the process pool for allocations on restart,
even if it does not occur on graceful restart, there is still
non-graceful restarts that will cause leaks.

What was excactly the issue with using pconf?

> 4. Change CPU thread count check from _SC_NPROCESSORS_ONLN to _SC_NPROCESSORS_CONF. This
makes sure num_buckets to be a constant as long as the system is running. This change addresses
the use case like: A user offline some of the CPU threads and then restart httpd. In this
case, I think we need to make sure num_buckets does not change during the restart.

Why would httpd always ignore offline CPUs and not take that into
account on restarts (at least non-graceful ones)?

Regards,
Yann.

Mime
View raw message