httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: [Patch] Async write completion for the full connection filter stack
Date Fri, 12 Sep 2014 15:04:24 GMT
This was just a POC, with coding mistakes...

On Fri, Sep 12, 2014 at 4:57 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
> [...]
> AP_DECLARE(apr_status_t) ap_filter_setaside_brigade(ap_filter_t *f,
>                                                     ap_filter_aside_t **aside,
>                                                     apr_pool_t
> **deferred_write_pool,

Forgot to remove this arg.

>                                                     apr_bucket_brigade *bb)
> [...]
> AP_DECLARE(int) ap_filter_reinstate_brigade(ap_filter_t *f,
>                                             ap_filter_aside_t *aside,
>                                             apr_bucket_brigade *bb,
>                                             apr_bucket **flush_upto)
> {
> [...]
>     if ((*aside)->bb && !APR_BRIGADE_EMPTY((*aside)->bb)) {
>         APR_BRIGADE_PREPEND(bb, (*aside)->bb);

Of course here, read aside-> instead of (*aside)->.

>         f->c->data_in_output_filters--;
>         if (empty) {
>             return 1;
>         }
>     }
>
>     ...
> }

Regards,
Yann.

Mime
View raw message