httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: [Patch] Async write completion for the full connection filter stack
Date Fri, 12 Sep 2014 15:52:08 GMT
On Fri, Sep 12, 2014 at 4:57 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
> AP_DECLARE(apr_status_t) ap_filter_setaside_brigade(ap_filter_t *f,
>                                                     ap_filter_aside_t **aside,
>                                                     apr_bucket_brigade *bb)
> {
>     if (!APR_BRIGADE_EMPTY(bb)) {
>         [...]
>     }
>     else if ((*aside)->pool) {

We'd probably better check *aside != NULL before here too.

>         [...]
>     }
>     return APR_SUCCESS;
> }

I think that's all :-p

Mime
View raw message