Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6A42E115C5 for ; Thu, 21 Aug 2014 15:25:51 +0000 (UTC) Received: (qmail 89168 invoked by uid 500); 21 Aug 2014 15:25:50 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 89082 invoked by uid 500); 21 Aug 2014 15:25:50 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 89072 invoked by uid 99); 21 Aug 2014 15:25:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Aug 2014 15:25:50 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of covener@gmail.com designates 209.85.215.45 as permitted sender) Received: from [209.85.215.45] (HELO mail-la0-f45.google.com) (209.85.215.45) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Aug 2014 15:25:24 +0000 Received: by mail-la0-f45.google.com with SMTP id ty20so8794984lab.32 for ; Thu, 21 Aug 2014 08:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=4KgQhqU3blKSxZADiXMpWca0583PBZOQCobt2LgIGIo=; b=ubfNgpBgA73Cr8Bvj3gUkRCSwFNaj+NkY+sVWXCcg4K4Mp/hssgPy2DRPblV0dtjJn wbYov5+i2IA7XHHw0yuBIJrWle8I4R2TfUeUg//InZhGfmgq+hl/9Wh+alZTjui5rvVp JAG68NUBaFtTsBzxQ5TcRMwXkKZfv6TIc0btJ/F0mqyKpBj4BaUCXnYNQV8gEbF7NThj KwdMCxyHC/yWlH5X3SaKlNSkzC14b/lTyJiwoPGqNPOmEUlPPNJy+qysFr+lhFBKW8vU riFH4VQiWDsPa1iidsPXqrmJrp789QtMgh82XOy99lHOaKEjUw/cArNrUU4tqDPuH1Lf 02IQ== MIME-Version: 1.0 X-Received: by 10.152.88.43 with SMTP id bd11mr4628168lab.89.1408634723757; Thu, 21 Aug 2014 08:25:23 -0700 (PDT) Received: by 10.25.83.208 with HTTP; Thu, 21 Aug 2014 08:25:23 -0700 (PDT) In-Reply-To: References: <20140821131115.E06182388A91@eris.apache.org> Date: Thu, 21 Aug 2014 11:25:23 -0400 Message-ID: Subject: Re: svn commit: r1619383 - /httpd/httpd/trunk/modules/filters/mod_deflate.c From: Eric Covener To: Apache HTTP Server Development List Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org On Thu, Aug 21, 2014 at 10:34 AM, Yann Ylavic wrote: > Should I apply it? yes, I think I see now that the removal is wrong and the other stuff is more readable. But I am a bit confused as to why we check only the ratio sometimes (in the blocks when moving the full zlib buffer to the heap bucket). Is it intentional? -- Eric Covener covener@gmail.com