httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Kalu┼ża <jkal...@redhat.com>
Subject Re: svn commit: r1599531 - in /httpd/httpd/trunk: CHANGES include/ap_listen.h server/listen.c server/mpm/event/event.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c server/mpm_unix.c
Date Tue, 19 Aug 2014 10:39:38 GMT
> @@ -3206,6 +3277,10 @@ static int event_pre_config(apr_pool_t *
>                           "atomics not working as expected - add32 of negative number");
>              return HTTP_INTERNAL_SERVER_ERROR;
>          }
> +        retained->idle_spawn_rate = apr_palloc(pconf, sizeof(int) * num_buckets);
> +        for (i = 0; i< num_buckets; i++) {
> +            retained->idle_spawn_rate[i] = 1;
> +        }
>          rv = apr_pollset_create(&event_pollset, 1, plog,
>                                  APR_POLLSET_THREADSAFE | APR_POLLSET_NOCOPY);
>          if (rv != APR_SUCCESS) {

Shouldn't this be done outside of "if (!one_process && !foreground)" 
condition? Otherwise in the case of -DFOREGROUND, it will crash because 
retained->idle_spawn_rate is NULL.

Jan Kaluza


Mime
View raw message