httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simo Sorce <s...@redhat.com>
Subject Re: [PATCH] Support RFC5929 - Channel Bindings for TLS
Date Wed, 27 Aug 2014 16:27:53 GMT
On Wed, 2014-08-27 at 17:15 +0100, Joe Orton wrote:
> On Wed, Aug 27, 2014 at 10:05:40AM -0400, Simo Sorce wrote:
> > Yes the spec is "strange" wrt digest, which is why the code looks
> > strange too, here is the quote from RFC 5929 (4.1):
> 
> Great, thanks.  It took me two commits due to PEBKAC issues...
> 
> http://svn.apache.org/viewvc?view=revision&revision=r1620926
> http://svn.apache.org/viewvc?view=revision&revision=r1620927
> 
> I made a couple of style & docs tweaks and adjusted the types, partly 
> because of compiler warnings:
> 
> - use apr_status_t not int for APR_* error codes in return value
> - switched to "unsigned char *" for the buffer type throughout
> - used unsigned int for the size parameter to X509_digest()
> 
> Hope these are OK, let me know if not!

Looks good to me,
Thanks a lot!

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York


Mime
View raw message