Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 874D711E20 for ; Tue, 8 Jul 2014 13:46:29 +0000 (UTC) Received: (qmail 74465 invoked by uid 500); 8 Jul 2014 13:46:29 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 74397 invoked by uid 500); 8 Jul 2014 13:46:29 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 74384 invoked by uid 99); 8 Jul 2014 13:46:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jul 2014 13:46:29 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of covener@gmail.com designates 209.85.220.176 as permitted sender) Received: from [209.85.220.176] (HELO mail-vc0-f176.google.com) (209.85.220.176) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jul 2014 13:46:26 +0000 Received: by mail-vc0-f176.google.com with SMTP id ik5so5399061vcb.21 for ; Tue, 08 Jul 2014 06:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=1hfHtiS4j1n3ZBst9I3BbYsz85KowRJuLjJ7fm6cPvo=; b=zwnkBgDGzUFM9n5NH3ssvnX5xq7x0jM/39wq3ilr7aZhgsaJp+lUN9p7QzF977SGUY aKx1Z6mRCB8Hz9gCi8RkXhZn++/dTjq+l/oUVAt91j9FClYx/N6EMNfQas6AQXLDUXlL viu50UAfeLzHmmNP+30ImArOcMEHUT+tgVS4QIgk/mIF1+5fooRCEyAvkIw2oz99fPtD 1liTAc6G6OaPVXN5oVq5+EcE1GXfk2IrJUhUwrCE0awf+uLkPMO/140oXpWkXY8Emaje hp/MDYYo/5EW3Stcpa5elORwtBNhRZiJDAWbuZN8344Lvb9zkS5kn+kzsfV7F7FQunG1 2UeA== MIME-Version: 1.0 X-Received: by 10.52.119.196 with SMTP id kw4mr174530vdb.75.1404827161299; Tue, 08 Jul 2014 06:46:01 -0700 (PDT) Received: by 10.58.243.73 with HTTP; Tue, 8 Jul 2014 06:46:01 -0700 (PDT) In-Reply-To: <20140628150112.6501B2388B43@eris.apache.org> References: <20140628150112.6501B2388B43@eris.apache.org> Date: Tue, 8 Jul 2014 09:46:01 -0400 Message-ID: Subject: Re: svn commit: r1606368 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/winnt/child.c From: Eric Covener To: Apache HTTP Server Development List Cc: cvs@httpd.apache.org Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org On Sat, Jun 28, 2014 at 11:01 AM, wrote: > @@ -1126,6 +1136,7 @@ void child_main(apr_pool_t *pconf, DWORD > rv = WaitForMultipleObjects(num_events, (HANDLE *)child_events, FALSE, INFINITE); > cld = rv - WAIT_OBJECT_0; > #else > + /* THIS IS THE EXPECTED BUILD VARIATION */ > rv = WaitForMultipleObjects(num_events, (HANDLE *)child_events, FALSE, 1000); > cld = rv - WAIT_OBJECT_0; > if (rv == WAIT_TIMEOUT) { Was reviewing for 2.4, what does the comment mean? -- Eric Covener covener@gmail.com