Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of ylavic.dev@gmail.com
 designates 209.85.213.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <53BD3D87.6040904@redhat.com>
References: <5236FD18.2060904@redhat.com>
	<53282D57.8090809@redhat.com>
	<CAKQ1sVOA4SnTHRgkWC_Mw4M1AYjWWD4qX2_qU70y9Jzx6uWQpQ@mail.gmail.com>
	<CAKQ1sVPBSoShvtUV1HFDTgHxv=GX1Eqn0FALnwiK93iBi-r5TA@mail.gmail.com>
	<53295C63.1030205@redhat.com>
	<CAKQ1sVPgK069x5pGvTL9siytP4eDZCeiFdCJ+Z-=Z6Qx07r5bw@mail.gmail.com>
	<CAKQ1sVP24-PyN_vfhvh8heMfBhFJzG9ya2C2Y3jspj_dco9XGQ@mail.gmail.com>
	<62604B63-7F47-4F47-B881-2C5E373C265A@jaguNET.com>
	<CAKQ1sVOU0BtDW4wLH2QVrMBqazo6gKXfmYCSqP8iB5U1e+9xuw@mail.gmail.com>
	<53465566.2020009@redhat.com>
	<53567129.7080406@redhat.com>
	<CAKQ1sVOXxYqDj904+f7kpipFm=zGxxQb8oM6B4_Q2iFLv+Kp_w@mail.gmail.com>
	<24486596-06E8-4478-8B4F-B8717102043B@jaguNET.com>
	<535F8FF7.3070801@redhat.com>
	<1BB4810C-FA51-46D6-BD3A-0C8C0597C370@jaguNET.com>
	<535F9DFC.9010605@redhat.com>
	<65401870-D6B0-428D-A97B-414E1ED245A9@jaguNET.com>
	<53BD3D87.6040904@redhat.com>
Date: Wed, 9 Jul 2014 16:14:22 +0200
Message-ID: 
 <CAKQ1sVOF5pTBFEvaCScVeL+yb5dhiAG=SbOmvbU4C4423AdY8A@mail.gmail.com>
Subject: Re: [PATCH] Fix settings options with ProxyPassMatch
From: Yann Ylavic <ylavic.dev@gmail.com>
To: httpd <dev@httpd.apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 9, 2014 at 3:03 PM, Jan Kalu=C5=BEa <jkaluza@redhat.com> wrote:
> Hi,
>
> could you please check the patch I've attached to this email?

Looks good to me.

>
> It changes following parts of Yann's patch:
>
> 1. keep only single name of the worker stored in shared memory.
>
> 2. when ProxyPassMatch is used, wshared->is_name_matchable =3D 1.
>
> 3. if is_name_matchable =3D=3D 1, ap_proxy_get_worker() uses
> ap_proxy_strcmp_ematch() which treats "$N" as '*'.

Much simpler, no need to store the pattern.

Would it be possible to handle some escaping character (eg. \), so
that $ can be expressed without being interpolated?
(There is still the comment in ap_proxy_strcmp_ematch(), but not the
code anymore).
AFAICT, $ is a legitimate URL character that need not be %-escaped.

Regards,
Yann.